setCurrentRange should ensure it moves ChromeVox to a valid range.

setCurrentRange should ensure it moves ChromeVox to a valid range.

The range, when navigating to dynamic widgets, sometimes detaches entirely from the document and only re-appears as a result of future events. Since we're observing children changed for active descendant changed, filter out events that result in a range pointing to a null node.

BUG=641213
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/bce91cf61af7f6200d5472cca7ea80ad677b358c
Cr-Commit-Position: refs/heads/master@{#415669}

[David Tseng, 2016-08-30 20:41:25]

Description was changed from

==========
setCurrentRange should ensure it moves ChromeVox to a valid range.
==========

to

==========
setCurrentRange should ensure it moves ChromeVox to a valid range.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-08-30 20:44:45]

Description was changed from

==========
setCurrentRange should ensure it moves ChromeVox to a valid range.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
setCurrentRange should ensure it moves ChromeVox to a valid range.

The range, when navigating to dynamic widgets, sometimes detaches entirely from
the document and only re-appears as a result of future events. Since we're
observing children changed for active descendant changed, filter out events that
result in a range pointing to a null node.

BUG=641213
==========

[David Tseng, 2016-08-30 20:44:45]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-08-30 21:04:37]

lgtm

[David Tseng, 2016-08-31 16:09:00]

Description was changed from

==========
setCurrentRange should ensure it moves ChromeVox to a valid range.

The range, when navigating to dynamic widgets, sometimes detaches entirely from
the document and only re-appears as a result of future events. Since we're
observing children changed for active descendant changed, filter out events that
result in a range pointing to a null node.

BUG=641213
==========

to

==========
setCurrentRange should ensure it moves ChromeVox to a valid range.

The range, when navigating to dynamic widgets, sometimes detaches entirely from
the document and only re-appears as a result of future events. Since we're
observing children changed for active descendant changed, filter out events that
result in a range pointing to a null node.

BUG=641213
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-08-31 16:09:05]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-08-31 16:09:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2296013002/#ps20001
(title: "Make sure newRange is defined.")

[commit-bot: I haz the power, 2016-08-31 16:09:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 17:22:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-31 17:26:20]

Description was changed from

==========
setCurrentRange should ensure it moves ChromeVox to a valid range.

The range, when navigating to dynamic widgets, sometimes detaches entirely from
the document and only re-appears as a result of future events. Since we're
observing children changed for active descendant changed, filter out events that
result in a range pointing to a null node.

BUG=641213
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
setCurrentRange should ensure it moves ChromeVox to a valid range.

The range, when navigating to dynamic widgets, sometimes detaches entirely from
the document and only re-appears as a result of future events. Since we're
observing children changed for active descendant changed, filter out events that
result in a range pointing to a null node.

BUG=641213
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/bce91cf61af7f6200d5472cca7ea80ad677b358c
Cr-Commit-Position: refs/heads/master@{#415669}
==========

[commit-bot: I haz the power, 2016-08-31 17:26:21]

Patchset 2 (id:??) landed as
https://crrev.com/bce91cf61af7f6200d5472cca7ea80ad677b358c
Cr-Commit-Position: refs/heads/master@{#415669}