Fix the crash bug of close button for the resolution change notification.

Fix the crash bug of close button for the resolution change notification.

Close() is invoked in RemoveNotification() before removing the
notification (because the NotificationDelegate is owned by its notification).
Invoking AcceptResolutionChange() directly here causes the removing
notification twice, which will cause a crash.

BUG=271784
R=oshima@chromium.org
TEST=covered by the new test case

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217338

[oshima, 2013-08-13 01:10:02]

the change LGTM, but please wait for https://codereview.chromium.org/22662005/
sync & fix the test before landing this.

https://codereview.chromium.org/22960004/diff/2001/ash/display/resolution_not...
File ash/display/resolution_notification_controller.h (right):

https://codereview.chromium.org/22960004/diff/2001/ash/display/resolution_not...
ash/display/resolution_notification_controller.h:54: // should be removed at the
same time.
nit

s/at the same time/upon invocation/ (or just "should be closed")

[Jun Mukai, 2013-08-13 02:24:11]

https://codereview.chromium.org/22960004/diff/2001/ash/display/resolution_not...
File ash/display/resolution_notification_controller.h (right):

https://codereview.chromium.org/22960004/diff/2001/ash/display/resolution_not...
ash/display/resolution_notification_controller.h:54: // should be removed at the
same time.
On 2013/08/13 01:10:03, oshima wrote:
> nit
> 
> s/at the same time/upon invocation/ (or just "should be closed")
> 

Done.

[Jun Mukai, 2013-08-13 16:50:15]

On 2013/08/13 02:24:11, Jun Mukai wrote:
>
https://codereview.chromium.org/22960004/diff/2001/ash/display/resolution_not...
> File ash/display/resolution_notification_controller.h (right):
> 
>
https://codereview.chromium.org/22960004/diff/2001/ash/display/resolution_not...
> ash/display/resolution_notification_controller.h:54: // should be removed at
the
> same time.
> On 2013/08/13 01:10:03, oshima wrote:
> > nit
> > 
> > s/at the same time/upon invocation/ (or just "should be closed")
> > 
> 
> Done.

sync&rebase&fix the new test done.

[commit-bot: I haz the power, 2013-08-13 16:51:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/22960004/8001

[commit-bot: I haz the power, 2013-08-13 20:58:43]

Change committed as 217338