Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7002)

Unified Diff: chrome/browser/password_manager/password_manager.h

Issue 22960002: [password autofill] Add stats on provisional save failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_manager.h
diff --git a/chrome/browser/password_manager/password_manager.h b/chrome/browser/password_manager/password_manager.h
index d65d1c7d449d5c2d7ca9280649eca73ad3e28a67..7167efda6a159b75499287a00bddd220af9c9e28 100644
--- a/chrome/browser/password_manager/password_manager.h
+++ b/chrome/browser/password_manager/password_manager.h
@@ -89,6 +89,20 @@ class PasswordManager : public LoginModel,
private:
friend class content::WebContentsUserData<PasswordManager>;
+ enum ProvisionalSaveFailure {
+ SAVING_DISABLED,
+ EMPTY_PASSWORD,
+ NO_MATCHING_FORM,
+ MATCHING_NOT_COMPLETE,
+ FORM_BLACKLISTED,
+ INVALID_FORM,
+ AUTOCOMPLETE_OFF,
+ MAX_FAILURE_VALUE
+ };
+
+ // Log failure for UMA
+ void RecordFailure(ProvisionalSaveFailure failure);
+
// Possibly set up FieldTrial for testing other possible usernames. This only
// happens if there are other_possible_usernames to be shown and the
// experiment hasn't already been initialized. We setup the experiment at
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698