Issue 22960002: [password autofill] Add stats on provisional save failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22960002: [password autofill] Add stats on provisional save failures. (Closed)

Created:
7 years, 4 months ago by Garrett Casto

Modified:
7 years, 4 months ago

Reviewers:
Alexei Svitkine (slow), tburkard

CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[password autofill] Add stats on provisional save failures. There are a large number of password submits that prerendering is observing that the password manager is ignoring. These stats should allow us to pinpoint what kind of submissions these are to determine if they matter for prerendering. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217511

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -6 lines)			Patch
M	chrome/browser/password_manager/password_manager.h	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/password_manager/password_manager.cc	View		4 chunks	+24 lines, -6 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View		2 chunks	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Garrett Casto

asvitkine: histograms.xml changes tburkard: Everything else

7 years, 4 months ago (2013-08-12 22:32:57 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/22960002/6001

7 years, 4 months ago (2013-08-13 18:10:30 UTC) #4

Garrett Casto

On 2013/08/13 15:05:46, Alexei Svitkine wrote: > lgtm > > Should this have a BUG= ...

7 years, 4 months ago (2013-08-13 18:14:04 UTC) #5

Message was sent while issue was closed.

Change committed as 217511

Expand Messages | Collapse Messages