Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2295963002: Remove GYP files from some smaller toplevel dirs. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews, tfarina, jam, pennymac+watch_chromium.org, darin-cc_chromium.org, caitkp+watch_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GYP files from some smaller toplevel dirs. These are now unused. TBR=dpranke Committed: https://crrev.com/cd1547c4256ff5fef8ee99ea3aa9eaab12c55bdb Cr-Commit-Position: refs/heads/master@{#415409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5111 lines) Patch
D apps/apps.gypi View 1 chunk +0 lines, -96 lines 0 comments Download
D base/base.gyp View 1 chunk +0 lines, -1811 lines 0 comments Download
D base/base.gypi View 1 chunk +0 lines, -1118 lines 0 comments Download
D base/base_nacl.gyp View 1 chunk +0 lines, -159 lines 0 comments Download
D chrome_elf/blacklist.gypi View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome_elf/chrome_elf.gyp View 1 chunk +0 lines, -223 lines 0 comments Download
D chrome_elf/dll_hash.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome_elf/nt_registry/nt_registry.gyp View 1 chunk +0 lines, -51 lines 0 comments Download
D crypto/crypto.gyp View 1 chunk +0 lines, -236 lines 0 comments Download
D crypto/crypto.gypi View 1 chunk +0 lines, -88 lines 0 comments Download
D crypto/crypto_nacl.gyp View 1 chunk +0 lines, -44 lines 0 comments Download
D dbus/dbus.gyp View 1 chunk +0 lines, -141 lines 0 comments Download
D ipc/ipc.gyp View 1 chunk +0 lines, -323 lines 0 comments Download
D ipc/ipc.gypi View 1 chunk +0 lines, -147 lines 0 comments Download
D ipc/ipc_nacl.gyp View 1 chunk +0 lines, -71 lines 0 comments Download
D rlz/rlz.gyp View 1 chunk +0 lines, -187 lines 0 comments Download
D sdch/sdch.gyp View 1 chunk +0 lines, -107 lines 0 comments Download
D sql/sql.gyp View 1 chunk +0 lines, -188 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brettw
4 years, 3 months ago (2016-08-30 19:32:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295963002/1
4 years, 3 months ago (2016-08-30 19:33:20 UTC) #3
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-30 20:13:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 20:33:30 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 20:35:47 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cd1547c4256ff5fef8ee99ea3aa9eaab12c55bdb
Cr-Commit-Position: refs/heads/master@{#415409}

Powered by Google App Engine
This is Rietveld 408576698