Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2295933003: [turbofan] Don't mark likely conversion as deferred. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't mark likely conversion as deferred. When changing from Tagged to Float64 representation, it's not unlikely to see a HeapNumber (or if feedback says so, an Oddball), so we shouldn't penalize the code that deals with this case by marking it as deferred. R=mvstanton@chromium.org BUG=v8:5267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/compiler/effect-control-linearizer.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-30 18:10:41 UTC) #1
mvstanton
lgtm
4 years, 3 months ago (2016-08-30 18:12:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295933003/1
4 years, 3 months ago (2016-08-30 18:14:49 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a35934a67347169e4c711751f212b90beb119cba Cr-Commit-Position: refs/heads/master@{#39025}
4 years, 3 months ago (2016-08-30 18:36:10 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 18:36:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698