Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/StringView.h

Issue 2295913003: [DevTools] Switch from platform/v8_inspector to v8/v8-inspector.h. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/StringView.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/StringView.h b/third_party/WebKit/Source/platform/v8_inspector/public/StringView.h
deleted file mode 100644
index 333cebfb26d2ab943220ecf971217f11c86b261b..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/platform/v8_inspector/public/StringView.h
+++ /dev/null
@@ -1,51 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// Note: this include guard is very specific to not clash with wtf. Will be changed after moving out of blink.
-#ifndef v8_inspector_public_StringView_h
-#define v8_inspector_public_StringView_h
-
-#include "platform/PlatformExport.h"
-
-#include <cctype>
-#include <stdint.h>
-
-namespace v8_inspector {
-
-class PLATFORM_EXPORT StringView {
-public:
- StringView()
- : m_is8Bit(true)
- , m_length(0)
- , m_characters8(nullptr) {}
-
- StringView(const uint8_t* characters, unsigned length)
- : m_is8Bit(true)
- , m_length(length)
- , m_characters8(characters) {}
-
- StringView(const uint16_t* characters, unsigned length)
- : m_is8Bit(false)
- , m_length(length)
- , m_characters16(characters) {}
-
- bool is8Bit() const { return m_is8Bit; }
- unsigned length() const { return m_length; }
-
- // TODO(dgozman): add DCHECK(m_is8Bit) to accessors once platform can be used here.
- const uint8_t* characters8() const { return m_characters8; }
- const uint16_t* characters16() const { return m_characters16; }
-
-private:
- bool m_is8Bit;
- unsigned m_length;
- union {
- const uint8_t* m_characters8;
- const uint16_t* m_characters16;
- };
-};
-
-} // namespace v8_inspector
-
-#endif // v8_inspector_public_StringView_h

Powered by Google App Engine
This is Rietveld 408576698