Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: third_party/WebKit/Source/devtools/scripts/compile_frontend.py

Issue 2295913003: [DevTools] Switch from platform/v8_inspector to v8/v8-inspector.h. (Closed)
Patch Set: rebase, gn only Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/scripts/compile_frontend.py
diff --git a/third_party/WebKit/Source/devtools/scripts/compile_frontend.py b/third_party/WebKit/Source/devtools/scripts/compile_frontend.py
index 5089a1ffe4970baa558fb666ce5ceccb21b2d2f6..63e7faf21e2c121b49706d166cf79a7213176498 100755
--- a/third_party/WebKit/Source/devtools/scripts/compile_frontend.py
+++ b/third_party/WebKit/Source/devtools/scripts/compile_frontend.py
@@ -71,7 +71,8 @@ def to_platform_path_exact(filepath):
scripts_path = path.dirname(path.abspath(__file__))
devtools_path = path.dirname(scripts_path)
inspector_path = path.join(path.dirname(devtools_path), 'core', 'inspector')
-v8_inspector_path = path.join(path.dirname(devtools_path), 'platform', 'v8_inspector')
+# TODO(dgozman): move these checks to v8.
+v8_inspector_path = path.join(path.dirname(devtools_path), os.pardir, os.pardir, os.pardir, 'v8', 'src', 'inspector')
Michael Achenbach 2016/09/07 06:56:23 nit: 80 chars. Maybe you should also put a path.no
dgozman 2016/09/07 21:17:06 blink doesn't enforce 80 chars rule :-)
devtools_frontend_path = path.join(devtools_path, 'front_end')
global_externs_file = to_platform_path(path.join(devtools_frontend_path, 'externs.js'))
protocol_externs_file = path.join(devtools_frontend_path, 'protocol_externs.js')

Powered by Google App Engine
This is Rietveld 408576698