Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2295913003: [DevTools] Switch from platform/v8_inspector to v8/v8-inspector.h. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 #include "modules/cachestorage/InspectorCacheStorageAgent.h" 64 #include "modules/cachestorage/InspectorCacheStorageAgent.h"
65 #include "modules/device_orientation/DeviceOrientationInspectorAgent.h" 65 #include "modules/device_orientation/DeviceOrientationInspectorAgent.h"
66 #include "modules/indexeddb/InspectorIndexedDBAgent.h" 66 #include "modules/indexeddb/InspectorIndexedDBAgent.h"
67 #include "modules/storage/InspectorDOMStorageAgent.h" 67 #include "modules/storage/InspectorDOMStorageAgent.h"
68 #include "modules/webdatabase/InspectorDatabaseAgent.h" 68 #include "modules/webdatabase/InspectorDatabaseAgent.h"
69 #include "platform/CrossThreadFunctional.h" 69 #include "platform/CrossThreadFunctional.h"
70 #include "platform/RuntimeEnabledFeatures.h" 70 #include "platform/RuntimeEnabledFeatures.h"
71 #include "platform/TraceEvent.h" 71 #include "platform/TraceEvent.h"
72 #include "platform/graphics/GraphicsContext.h" 72 #include "platform/graphics/GraphicsContext.h"
73 #include "platform/graphics/paint/PaintController.h" 73 #include "platform/graphics/paint/PaintController.h"
74 #include "platform/v8_inspector/public/V8Inspector.h"
75 #include "platform/v8_inspector/public/V8InspectorSession.h"
76 #include "public/platform/Platform.h" 74 #include "public/platform/Platform.h"
77 #include "public/platform/WebLayerTreeView.h" 75 #include "public/platform/WebLayerTreeView.h"
78 #include "public/platform/WebRect.h" 76 #include "public/platform/WebRect.h"
79 #include "public/platform/WebString.h" 77 #include "public/platform/WebString.h"
80 #include "public/web/WebDevToolsAgentClient.h" 78 #include "public/web/WebDevToolsAgentClient.h"
81 #include "public/web/WebSettings.h" 79 #include "public/web/WebSettings.h"
82 #include "web/DevToolsEmulator.h" 80 #include "web/DevToolsEmulator.h"
83 #include "web/InspectorEmulationAgent.h" 81 #include "web/InspectorEmulationAgent.h"
84 #include "web/InspectorOverlay.h" 82 #include "web/InspectorOverlay.h"
85 #include "web/InspectorRenderingAgent.h" 83 #include "web/InspectorRenderingAgent.h"
86 #include "web/WebFrameWidgetImpl.h" 84 #include "web/WebFrameWidgetImpl.h"
87 #include "web/WebInputEventConversion.h" 85 #include "web/WebInputEventConversion.h"
88 #include "web/WebLocalFrameImpl.h" 86 #include "web/WebLocalFrameImpl.h"
89 #include "web/WebSettingsImpl.h" 87 #include "web/WebSettingsImpl.h"
90 #include "web/WebViewImpl.h" 88 #include "web/WebViewImpl.h"
91 #include "wtf/MathExtras.h" 89 #include "wtf/MathExtras.h"
92 #include "wtf/Noncopyable.h" 90 #include "wtf/Noncopyable.h"
93 #include "wtf/PtrUtil.h" 91 #include "wtf/PtrUtil.h"
94 #include "wtf/text/WTFString.h" 92 #include "wtf/text/WTFString.h"
95 #include <memory> 93 #include <memory>
94 #include <v8-inspector.h>
96 95
97 namespace blink { 96 namespace blink {
98 97
99 namespace { 98 namespace {
100 99
101 bool isMainFrame(WebLocalFrameImpl* frame) 100 bool isMainFrame(WebLocalFrameImpl* frame)
102 { 101 {
103 // TODO(dgozman): sometimes view->mainFrameImpl() does return null, even tho ugh |frame| is meant to be main frame. 102 // TODO(dgozman): sometimes view->mainFrameImpl() does return null, even tho ugh |frame| is meant to be main frame.
104 // See http://crbug.com/526162. 103 // See http://crbug.com/526162.
105 return frame->viewImpl() && !frame->parent(); 104 return frame->viewImpl() && !frame->parent();
(...skipping 580 matching lines...) Expand 10 before | Expand all | Expand 10 after
686 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method) 685 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method)
687 { 686 {
688 return method == "Debugger.pause" 687 return method == "Debugger.pause"
689 || method == "Debugger.setBreakpoint" 688 || method == "Debugger.setBreakpoint"
690 || method == "Debugger.setBreakpointByUrl" 689 || method == "Debugger.setBreakpointByUrl"
691 || method == "Debugger.removeBreakpoint" 690 || method == "Debugger.removeBreakpoint"
692 || method == "Debugger.setBreakpointsActive"; 691 || method == "Debugger.setBreakpointsActive";
693 } 692 }
694 693
695 } // namespace blink 694 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698