systrace/profile_chrome/perf_tracing_agent_unittest.py - Issue 2295913002: Enable some profile_chrome unit tests on Trybots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: systrace/profile_chrome/perf_tracing_agent_unittest.py

Issue 2295913002: Enable some profile_chrome unit tests on Trybots (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master

Patch Set: Disable DDMS test because it is flaky Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« systrace/profile_chrome/chrome_tracing_agent.py ('K') | « systrace/profile_chrome/ddms_tracing_agent_unittest.py ('k') | systrace/profile_chrome/profiler_unittest.py » ('j') | systrace/profile_chrome/util.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: systrace/profile_chrome/perf_tracing_agent_unittest.py

diff --git a/systrace/profile_chrome/perf_tracing_agent_unittest.py b/systrace/profile_chrome/perf_tracing_agent_unittest.py

index cd90b3691744ee7cd8982fc8279fe830d689f252..31c10095c051172b93856825a8b43147e7b306b3 100644

--- a/systrace/profile_chrome/perf_tracing_agent_unittest.py

+++ b/systrace/profile_chrome/perf_tracing_agent_unittest.py

@@ -7,9 +7,11 @@ import json

from profile_chrome import agents_unittest

from profile_chrome import perf_tracing_agent

from profile_chrome import ui

+from systrace import decorators

class PerfProfilerAgentTest(agents_unittest.BaseAgentTest):

+ @decorators.ClientOnlyTest

def testGetCategories(self):

if not perf_tracing_agent.PerfProfilerAgent.IsSupported():

return

@@ -17,6 +19,9 @@ class PerfProfilerAgentTest(agents_unittest.BaseAgentTest):

perf_tracing_agent.PerfProfilerAgent.GetCategories(self.device)

assert 'cycles' in ' '.join(categories)

+ # TODO: Try enabling this test for the SimpleperfProfilerAgent, which will

Sami 2016/09/09 10:28:25 nit: User name missing.

washingtonp 2016/09/09 18:07:29 Done.

+ # be added later.

+ @decorators.Disabled

def testTracing(self):

if not perf_tracing_agent.PerfProfilerAgent.IsSupported():

return