systrace/profile_chrome/agents_unittest.py - Issue 2295913002: Enable some profile_chrome unit tests on Trybots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: systrace/profile_chrome/agents_unittest.py

Issue 2295913002: Enable some profile_chrome unit tests on Trybots (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master

Patch Set: Disable DDMS test because it is flaky Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: systrace/profile_chrome/agents_unittest.py

diff --git a/systrace/profile_chrome/agents_unittest.py b/systrace/profile_chrome/agents_unittest.py

index 527162cfcf9dab8b3f0e9a46fba65a81f97dfde0..478d229457be11a329a84dc620f0c113da4559f7 100644

--- a/systrace/profile_chrome/agents_unittest.py

+++ b/systrace/profile_chrome/agents_unittest.py

@@ -5,9 +5,9 @@

import unittest

from profile_chrome import profiler

+from profile_chrome import util

from devil.android import device_utils

-from devil.android.sdk import intent

class BaseAgentTest(unittest.TestCase):

@@ -17,8 +17,6 @@ class BaseAgentTest(unittest.TestCase):

self.package_info = profiler.GetSupportedBrowsers()[self.browser]

self.device = devices[0]

- self.device.ForceStop(self.package_info.package)

- self.device.StartActivity(

- intent.Intent(activity=self.package_info.activity,

- package=self.package_info.package),

- blocking=True)

+ curr_browser = util.GetChromeProcessID(self.device, self.package_info)

+ if curr_browser == None:

+ util.StartBrowser(self.device, self.package_info)

« no previous file with comments | « systrace/bin/run_tests ('k') | systrace/profile_chrome/atrace_tracing_agent_unittest.py » ('j') | systrace/profile_chrome/chrome_tracing_agent.py » ('J')