Reconcile BSD and GNU sed

Reconcile BSD and GNU sed

Since there does not appear to be an overlapping way to specify an empty
'backup' string, use .bak and remove the file afterwards in accordance
with the wisdom of stackoverflow.

Committed: https://crrev.com/7c4249fb0a27e1841f48b6d39773d3966b6acdbf
Cr-Commit-Position: refs/heads/master@{#415723}

[Johann, 2016-08-30 17:30:11]

johannkoenig@google.com changed reviewers:
+ jzern@chromium.org

[Johann, 2016-08-30 17:31:50]

Oops, should have tested myself. This clears up:
sed: can't read : No such file or directory

when sed tries to treat '' as an input file. It still worked, but it terminated
at the failure. I suppose another option would be to suppress the error.

[jzern, 2016-08-30 23:57:53]

https://codereview.chromium.org/2295903003/diff/1/third_party/libvpx/generate...
File third_party/libvpx/generate_gypi.sh (left):

https://codereview.chromium.org/2295903003/diff/1/third_party/libvpx/generate...
third_party/libvpx/generate_gypi.sh:461: sed -E -i '' \
this was my mistake, when testing I think I had the conditions backwards. I had
it correct in an earlier patch, -i'' (no space) should work. Linux reports the
same error with a space between params.

[jzern, 2016-08-31 18:19:09]

lgtm

https://codereview.chromium.org/2295903003/diff/1/third_party/libvpx/generate...
File third_party/libvpx/generate_gypi.sh (left):

https://codereview.chromium.org/2295903003/diff/1/third_party/libvpx/generate...
third_party/libvpx/generate_gypi.sh:461: sed -E -i '' \
On 2016/08/30 23:57:53, jzern wrote:
> this was my mistake, when testing I think I had the conditions backwards. I
had
> it correct in an earlier patch, -i'' (no space) should work. Linux reports the
> same error with a space between params.

I was wrong, abutting it on OSX will consume the next arg '-e' and use that as
the extension

[Johann, 2016-08-31 18:42:01]

The CQ bit was checked by johannkoenig@google.com

[commit-bot: I haz the power, 2016-08-31 18:43:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 19:30:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-31 19:33:22]

Description was changed from

==========
Reconcile BSD and GNU sed

Since there does not appear to be an overlapping way to specify an empty
'backup' string, use .bak and remove the file afterwards in accordance
with the wisdom of stackoverflow.
==========

to

==========
Reconcile BSD and GNU sed

Since there does not appear to be an overlapping way to specify an empty
'backup' string, use .bak and remove the file afterwards in accordance
with the wisdom of stackoverflow.

Committed: https://crrev.com/7c4249fb0a27e1841f48b6d39773d3966b6acdbf
Cr-Commit-Position: refs/heads/master@{#415723}
==========

[commit-bot: I haz the power, 2016-08-31 19:33:23]

Patchset 1 (id:??) landed as
https://crrev.com/7c4249fb0a27e1841f48b6d39773d3966b6acdbf
Cr-Commit-Position: refs/heads/master@{#415723}