Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2295903002:
Include type_traits in safe_conversions_impl (Closed)
|
Created:
4 years, 3 months ago by Tom (Use chromium acct) Modified:
4 years, 3 months ago Reviewers:
Lei Zhang CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionInclude type_traits in safe_conversions_impl
type_traits adds std::is_arithmetic which is used in
safe_conversions_impl.h, however this header was not
included.
This is reported as an error by flycheck-clang (using my
system clang version 3.4, system headers, and --std=c++1y),
and is causing every source file that has
safe_conversions_impl.h as a dependency (about 13,000 of
them) to fail to syntax check anything after the include.
Committed: https://crrev.com/61500f21a9f93247d9b02fa86c7f619e02bb7fb8
Cr-Commit-Position: refs/heads/master@{#415530}
Patch Set 1 #
Messages
Total messages: 19 (14 generated)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Include type_traits in safe_conversions_impl ========== to ========== Include type_traits in safe_conversions_impl type_traits adds std::is_arithmetic which is used in safe_conversions_impl.h, however this header was not included. This is reported as an error by flycheck-clang (using my system clang version 3.4, system headers, and --std=c++1y), and is causing every source file that has safe_conversions_impl.h as a dependency (about 13,000 of them) to fail to syntax check anything after the include. ==========
thomasanderson@google.com changed reviewers: + thestig@chromium.org
Description was changed from ========== Include type_traits in safe_conversions_impl type_traits adds std::is_arithmetic which is used in safe_conversions_impl.h, however this header was not included. This is reported as an error by flycheck-clang (using my system clang version 3.4, system headers, and --std=c++1y), and is causing every source file that has safe_conversions_impl.h as a dependency (about 13,000 of them) to fail to syntax check anything after the include. ========== to ========== Include type_traits in safe_conversions_impl type_traits adds std::is_arithmetic which is used in safe_conversions_impl.h, however this header was not included. This is reported as an error by flycheck-clang (using my system clang version 3.4, system headers, and --std=c++1y), and is causing every source file that has safe_conversions_impl.h as a dependency (about 13,000 of them) to fail to syntax check anything after the include. ==========
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Include type_traits in safe_conversions_impl type_traits adds std::is_arithmetic which is used in safe_conversions_impl.h, however this header was not included. This is reported as an error by flycheck-clang (using my system clang version 3.4, system headers, and --std=c++1y), and is causing every source file that has safe_conversions_impl.h as a dependency (about 13,000 of them) to fail to syntax check anything after the include. ========== to ========== Include type_traits in safe_conversions_impl type_traits adds std::is_arithmetic which is used in safe_conversions_impl.h, however this header was not included. This is reported as an error by flycheck-clang (using my system clang version 3.4, system headers, and --std=c++1y), and is causing every source file that has safe_conversions_impl.h as a dependency (about 13,000 of them) to fail to syntax check anything after the include. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Include type_traits in safe_conversions_impl type_traits adds std::is_arithmetic which is used in safe_conversions_impl.h, however this header was not included. This is reported as an error by flycheck-clang (using my system clang version 3.4, system headers, and --std=c++1y), and is causing every source file that has safe_conversions_impl.h as a dependency (about 13,000 of them) to fail to syntax check anything after the include. ========== to ========== Include type_traits in safe_conversions_impl type_traits adds std::is_arithmetic which is used in safe_conversions_impl.h, however this header was not included. This is reported as an error by flycheck-clang (using my system clang version 3.4, system headers, and --std=c++1y), and is causing every source file that has safe_conversions_impl.h as a dependency (about 13,000 of them) to fail to syntax check anything after the include. Committed: https://crrev.com/61500f21a9f93247d9b02fa86c7f619e02bb7fb8 Cr-Commit-Position: refs/heads/master@{#415530} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/61500f21a9f93247d9b02fa86c7f619e02bb7fb8 Cr-Commit-Position: refs/heads/master@{#415530} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
