Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2295883004: [turbofan] Base more write barrier decisions on machine representation. (Closed)

Created:
4 years, 3 months ago by mvstanton
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Base more write barrier decisions on machine representation. This furthers our goal of avoiding using the representation dimension of the Type class. BUG=v8:5270 Committed: https://crrev.com/b8dec98dab6a61ddf74cf144d161e67f22af8263 Cr-Commit-Position: refs/heads/master@{#39064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/representation-change.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 5 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mvstanton
Hi Benedikt, Here is the step we discussed this morning, thanks for the look, --Mike
4 years, 3 months ago (2016-08-31 14:33:54 UTC) #4
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-08-31 17:00:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295883004/1
4 years, 3 months ago (2016-09-01 07:03:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 07:05:39 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 07:06:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8dec98dab6a61ddf74cf144d161e67f22af8263
Cr-Commit-Position: refs/heads/master@{#39064}

Powered by Google App Engine
This is Rietveld 408576698