Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args.html

Issue 2295863002: Remove window.postMessage(message, transferables, targetOrigin) legacy overload (Closed)
Patch Set: leave milestoneString alone Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args.html b/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args.html
index 6b7bdb0517b695f46df5939c7a0be43e1e7ed484..7f2eeb862d6f04d195080454b4b5b4c2425f5aeb 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args.html
@@ -48,18 +48,14 @@ function tryPostMessage(first, second, third, shouldFail) {
document.getElementById("description").innerHTML = "Test that the second argument of window.postMessage is ignored or triggers an error if it is not a message port. You should see PASS message '1' through '7', followed by 'done', with messages 4-7 received below.<br><br>";
tryPostMessage('1', '*', 1, true);
-tryPostMessage('2', '*', 'c', true); // Legacy overload resolution will consider 3rd argument to be the (string) origin.
+tryPostMessage('2', '*', 'c', true);
tryPostMessage('3', '*', { x: 1 }, true);
-tryPostMessage('3a', { x: 1 }, '*', true); // Legacy argument order.
tryPostMessage('4', '*', window); // Passes because window has a "length" attribute of value '0', so it looks like an array
-tryPostMessage('4a', window, '*'); // Legacy argument order.
tryPostMessage('5', '*', undefined);
tryPostMessage('5a', '*', null, true);
tryPostMessage('6', '*', void 0);
var channel1 = new MessageChannel;
tryPostMessageFunction(window.postMessage, '7', '*', [channel1.port1, channel1.port2]);
-var channel1a = new MessageChannel;
-tryPostMessageFunction(window.postMessage, '7a', [channel1a.port1, channel1a.port2], '*');
var channel2 = new MessageChannel;
tryPostMessageFunction(window.postMessage, '7', '*', [channel2.port1, channel2.port2]);
var channel3 = new MessageChannel;

Powered by Google App Engine
This is Rietveld 408576698