Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2295743003: Revert of Refactor object/class literal property name parsing (Closed)

Created:
4 years, 3 months ago by adamk
Modified:
4 years, 3 months ago
Reviewers:
bakkot, Dan Ehrenberg, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Refactor object/class literal property name parsing (patchset #7 id:120001 of https://codereview.chromium.org/2278153004/ ) Reason for revert: Fails to reject "{*foo: 1}" as an object literal, found by the fuzzer: https://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/12315/steps/Fuzz%20on%20Ubuntu-12.04/logs/stdio Original issue's description: > Refactor object/class literal property name parsing > > This patch arranges that property names are parsed in a single pass, > reporting the name as well as the type of the property, instead of > parsing qualifiers like 'static' or 'get' initially as names and then > re-parsing. This change is easier to reason about, very slightly (4%) > faster in some cases (although slower in other, less common ones, though > this slowdown will be fixed in an upcoming patch), and is a prerequisite > for separating the parsing of object and class literal properties, which > will become increasingly important as ECMAScript adds more class features. > > Committed: https://crrev.com/6dd26c729584024e17a05a2a76b319d4aecdc138 > Cr-Commit-Position: refs/heads/master@{#39027} TBR=littledan@chromium.org,marja@chromium.org,bakkot@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b9810ba0631ce3b5323ea9b97a423257f6fbcbda Cr-Commit-Position: refs/heads/master@{#39029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -252 lines) Patch
M src/parsing/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser-base.h View 12 chunks +154 lines, -248 lines 0 comments Download
M src/parsing/preparser.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
adamk
Created Revert of Refactor object/class literal property name parsing
4 years, 3 months ago (2016-08-31 00:38:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295743003/1
4 years, 3 months ago (2016-08-31 00:38:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 00:38:59 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 00:39:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9810ba0631ce3b5323ea9b97a423257f6fbcbda
Cr-Commit-Position: refs/heads/master@{#39029}

Powered by Google App Engine
This is Rietveld 408576698