[wasm] Refactor BuildWasmToJSWrapper to clearly separate direct calls from Call-codestub calls

[wasm] Refactor BuildWasmToJSWrapper to clearly separate direct calls from Call-codestub calls

Looking at the code with Toon showed me that the code is not really
readable at the moment. This refactoring should make the different kinds
of calls and their parameters more apparent.

R=titzer@chromium.org

Committed: https://crrev.com/e809937eb33e4cfafd062f0f2baa89e544ba9c49
Cr-Commit-Position: refs/heads/master@{#39126}

[ahaas, 2016-08-30 12:08:11]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 12:08:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 12:30:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 12:30:49]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-09-01 14:35:17]

https://codereview.chromium.org/2295743002/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2295743002/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:2573: // Convert WASM numbers to JS values.
Is it possible to factor this loop out with its carbon-copy below?

[ahaas, 2016-09-01 17:17:28]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 17:17:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-09-01 17:17:52]

https://codereview.chromium.org/2295743002/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2295743002/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:2573: // Convert WASM numbers to JS values.
On 2016/09/01 at 14:35:17, titzer wrote:
> Is it possible to factor this loop out with its carbon-copy below?

Done.

[commit-bot: I haz the power, 2016-09-01 17:50:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 17:50:31]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-09-02 07:39:50]

lgtm

[ahaas, 2016-09-02 10:52:47]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-09-02 10:52:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 10:54:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-02 10:55:40]

Description was changed from

==========
[wasm] Refactor BuildWasmToJSWrapper to clearly separate direct calls from
Call-codestub calls

Looking at the code with Toon showed me that the code is not really
readable at the moment. This refactoring should make the different kinds
of calls and their parameters more apparent.

R=titzer@chromium.org
==========

to

==========
[wasm] Refactor BuildWasmToJSWrapper to clearly separate direct calls from
Call-codestub calls

Looking at the code with Toon showed me that the code is not really
readable at the moment. This refactoring should make the different kinds
of calls and their parameters more apparent.

R=titzer@chromium.org

Committed: https://crrev.com/e809937eb33e4cfafd062f0f2baa89e544ba9c49
Cr-Commit-Position: refs/heads/master@{#39126}
==========

[commit-bot: I haz the power, 2016-09-02 10:55:40]

Patchset 2 (id:??) landed as
https://crrev.com/e809937eb33e4cfafd062f0f2baa89e544ba9c49
Cr-Commit-Position: refs/heads/master@{#39126}