Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 2295733002: Add page load metrics owners for WebPerformance.h/.cpp (Closed)

Created:
4 years, 3 months ago by Bryan McQuade
Modified:
4 years, 3 months ago
Reviewers:
Nate Chapin, dglazkov
CC:
abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, Charlie Harrison
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add page load metrics owners for WebPerformance.h/.cpp WebPerformance.h/.cpp are the public access points for exposing new page load metrics used by the metrics tracking code in chrome/. This change adds page load metrics owners as owners for these files, so we don't have to get reviews from blink 'web' owners each time we expose a new metric. Committed: https://crrev.com/a0bb947d15a143d822bac0302b5bd27f77cbf870 Cr-Commit-Position: refs/heads/master@{#416707}

Patch Set 1 #

Patch Set 2 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/web/OWNERS View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/OWNERS View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Bryan McQuade
japhet, PTAL, thanks!
4 years, 3 months ago (2016-08-30 12:08:21 UTC) #4
dglazkov
This is a little unorthodox. Could we maybe just designate a person, rather than use ...
4 years, 3 months ago (2016-09-06 18:01:43 UTC) #7
Bryan McQuade
Sure, absolutely, I'll change it so I'm the only owner. On Tue, Sep 6, 2016 ...
4 years, 3 months ago (2016-09-06 18:03:03 UTC) #8
Bryan McQuade
Sure, absolutely, I'll change it so I'm the only owner. On Tue, Sep 6, 2016 ...
4 years, 3 months ago (2016-09-06 18:03:03 UTC) #9
Bryan McQuade
Just updated the change. I added two people, myself and csharrison, so we have a ...
4 years, 3 months ago (2016-09-06 18:37:47 UTC) #10
Bryan McQuade
Just updated the change. I added two people, myself and csharrison, so we have a ...
4 years, 3 months ago (2016-09-06 18:37:48 UTC) #11
dglazkov
lgtm
4 years, 3 months ago (2016-09-06 18:38:37 UTC) #13
Nate Chapin
lgtm
4 years, 3 months ago (2016-09-06 18:41:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295733002/20001
4 years, 3 months ago (2016-09-06 19:05:18 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 20:35:36 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 20:38:53 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0bb947d15a143d822bac0302b5bd27f77cbf870
Cr-Commit-Position: refs/heads/master@{#416707}

Powered by Google App Engine
This is Rietveld 408576698