Issue 2295723007: owners_unittest.py: Add tests of interaction between per-file owners,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2295723007: owners_unittest.py: Add tests of interaction between per-file owners,

Created:
4 years, 3 months ago by ncarter (slow)

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

owners_unittest.py: Add tests of interaction between per-file owners, per-file noparent. These tests fail currently. Remove the top-level '*' from /OWNERS in these tests; that's an unrealistic use case and makes it too easy to write lame tests by accident here. Add that global permission back in to the couple of tests that depend on it. BUG=

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -5 lines)			Patch
	M	tests/owners_unittest.py	View		9 chunks	+46 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ncarter (slow)

4 years, 3 months ago (2016-09-01 21:37:29 UTC) #1

Description was changed from

==========
owners_unittest.py: Add tests of interaction between per-file owners,
per-file noparent. These test fail currently.

Remove the top-level '*' from /OWNERS in these tests; that's an unrealistic
use case and makes it too easy to write lame tests by accident here.
Add that global permission back in to the couple of tests that depend on it.

BUG=
==========

to

==========
owners_unittest.py: Add tests of interaction between per-file owners,
per-file noparent. These tests fail currently.

Remove the top-level '*' from /OWNERS in these tests; that's an unrealistic
use case and makes it too easy to write lame tests by accident here.
Add that global permission back in to the couple of tests that depend on it.

BUG=
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages