Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2295723004: Combined Roll WebRTC 13978:13983 (5 commits) and override tq (Closed)

Created:
4 years, 3 months ago by perkj_chrome
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll WebRTC 13978:13983 (5 commits) Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/854d164..e5dcf5c $ git log 854d164..e5dcf5c --date=short --no-merges --format=%ad %ae %s 2016-08-30 perkj@webrtc.org Do not build task_queue.cc and include from webrtc_overrides in Chrome. This is step 2 of the plan below. 2016-08-30 honghaiz@webrtc.org Add a switch to redetermine role when ICE restarts. 2016-08-30 hbos@webrtc.org Making hbos and hta OWNERS of webrtc/api/rtcstats*. 2016-08-30 kjellander@webrtc.org MB: Flip iOS bots to GN by default 2016-08-30 hbos@webrtc.org RTCStatsCollector and RTCPeerConnectionStats added. Override webrtc task_queue.cc and task_queue.h. This is step 3 of the plan below. The modified plan 1. First land unmodified task_queue.h into webrtc_override in Chrome 2. Modify build files in the webrtc repo to include the task_queue.h and task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI. 3. Combine a roll of webrtc to Chrome and this cl into one cl. The combined cl will roll in build files from 2 and add task_queue.cc in webrtc_overrides and build task_queue_unittest.cc as part of content_unittests to test task_queue.cc in webrtc_overrides. 4... Start using task queues in webrtc........ TBR=tommi@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=webrtc:5687 Committed: https://crrev.com/103f0540f76575623233d1086cc29a8a75de61d0 Cr-Commit-Position: refs/heads/master@{#415579}

Patch Set 1 #

Patch Set 2 : Override webrtc task_queue.cc and task_queue.h. This is step 3 of the plan below. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -67 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/webrtc_overrides/webrtc/base/task_queue.h View 1 3 chunks +7 lines, -66 lines 0 comments Download
A third_party/webrtc_overrides/webrtc/base/task_queue.cc View 1 1 chunk +135 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
perkj_chrome
4 years, 3 months ago (2016-08-31 06:11:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295723004/20001
4 years, 3 months ago (2016-08-31 06:14:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 07:37:05 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 07:38:59 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/103f0540f76575623233d1086cc29a8a75de61d0
Cr-Commit-Position: refs/heads/master@{#415579}

Powered by Google App Engine
This is Rietveld 408576698