Add an option --gn to run-tests.py that just runs the latest gn build

Add an option --gn to run-tests.py that just runs the latest gn build

R=machenbach@chromium.org
BUG=

Committed: https://crrev.com/c3e1b5f87ccc82f8eefe63e7c220d5c95f496d52
Cr-Commit-Position: refs/heads/master@{#39011}

[jochen (gone - plz use gerrit), 2016-08-30 09:54:46]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 09:54:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 10:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 10:20:04]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-08-30 11:32:17]

https://codereview.chromium.org/2295703002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/2295703002/diff/1/tools/run-tests.py#newcode436
tools/run-tests.py:436: latest_timestamp =  -1
nit: space too much

https://codereview.chromium.org/2295703002/diff/1/tools/run-tests.py#newcode442
tools/run-tests.py:442: if os.path.getmtime(gn_config_dir) > latest_timestamp:
The modified time of the directory only changes if you add/remove files. What if
all files keep existing and are just modified?

[jochen (gone - plz use gerrit), 2016-08-30 11:40:54]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[jochen (gone - plz use gerrit), 2016-08-30 11:40:59]

https://codereview.chromium.org/2295703002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/2295703002/diff/1/tools/run-tests.py#newcode436
tools/run-tests.py:436: latest_timestamp =  -1
On 2016/08/30 at 11:32:17, machenbach (slow) wrote:
> nit: space too much

done

https://codereview.chromium.org/2295703002/diff/1/tools/run-tests.py#newcode442
tools/run-tests.py:442: if os.path.getmtime(gn_config_dir) > latest_timestamp:
On 2016/08/30 at 11:32:17, machenbach (slow) wrote:
> The modified time of the directory only changes if you add/remove files. What
if all files keep existing and are just modified?

I think compiling will always first remove the target and add it (at least in my
local test that seems to work)

[commit-bot: I haz the power, 2016-08-30 11:41:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-08-30 11:51:03]

lgtm

https://codereview.chromium.org/2295703002/diff/20001/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/2295703002/diff/20001/tools/run-tests.py#newc...
tools/run-tests.py:699: print(">>> Running tests for %s.%s" % (arch, mode))
Optional suggestion: Maybe print the last piece of the directory here in case
the gn option was used? To avoid silently testing something that's undesired?

[commit-bot: I haz the power, 2016-08-30 12:03:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 12:03:55]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-08-30 12:13:15]

On 2016/08/30 at 11:51:03, machenbach wrote:
> lgtm
> 
> https://codereview.chromium.org/2295703002/diff/20001/tools/run-tests.py
> File tools/run-tests.py (right):
> 
>
https://codereview.chromium.org/2295703002/diff/20001/tools/run-tests.py#newc...
> tools/run-tests.py:699: print(">>> Running tests for %s.%s" % (arch, mode))
> Optional suggestion: Maybe print the last piece of the directory here in case
the gn option was used? To avoid silently testing something that's undesired?

run-tests already prints that: 

eisinger@eisinger0-w MINGW64 /c/src/v8 (outdir)
$ tools/run-tests.py --gn
>>> Running tests for x64.debug
[02:02|% 100|+ 25051|-   0]: Done


is that good enough?

[Michael Achenbach, 2016-08-30 12:16:11]

On 2016/08/30 12:13:15, jochen wrote:
> On 2016/08/30 at 11:51:03, machenbach wrote:
> > lgtm
> > 
> > https://codereview.chromium.org/2295703002/diff/20001/tools/run-tests.py
> > File tools/run-tests.py (right):
> > 
> >
>
https://codereview.chromium.org/2295703002/diff/20001/tools/run-tests.py#newc...
> > tools/run-tests.py:699: print(">>> Running tests for %s.%s" % (arch, mode))
> > Optional suggestion: Maybe print the last piece of the directory here in
case
> the gn option was used? To avoid silently testing something that's undesired?
> 
> run-tests already prints that: 
> 
> eisinger@eisinger0-w MINGW64 /c/src/v8 (outdir)
> $ tools/run-tests.py --gn
> >>> Running tests for x64.debug
> [02:02|% 100|+ 25051|-   0]: Done
> 
> 
> is that good enough?

Hmm, probably. The new folders are more generic and one could have several
folders with the same kind of build. Or folders with builds that differ in other
parameters than  arch.mode. But we can deliver more printing later...

Still lgtm

[jochen (gone - plz use gerrit), 2016-08-30 12:17:13]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-08-30 12:17:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 12:21:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 12:21:36]

Description was changed from

==========
Add an option --gn to run-tests.py that just runs the latest gn build

R=machenbach@chromium.org
BUG=
==========

to

==========
Add an option --gn to run-tests.py that just runs the latest gn build

R=machenbach@chromium.org
BUG=

Committed: https://crrev.com/c3e1b5f87ccc82f8eefe63e7c220d5c95f496d52
Cr-Commit-Position: refs/heads/master@{#39011}
==========

[commit-bot: I haz the power, 2016-08-30 12:21:37]

Patchset 2 (id:??) landed as
https://crrev.com/c3e1b5f87ccc82f8eefe63e7c220d5c95f496d52
Cr-Commit-Position: refs/heads/master@{#39011}