Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1831)

Unified Diff: android_webview/native/aw_contents_background_thread_client.cc

Issue 2295693004: Pass JavaRef to Java methods in android_webview. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_contents_background_thread_client.cc
diff --git a/android_webview/native/aw_contents_background_thread_client.cc b/android_webview/native/aw_contents_background_thread_client.cc
index 138d9a4b5821c6ed4ce678605a0426a6030ef03f..d2fa3de8d2ccb714bd808a2d87a7b9a27675ebe2 100644
--- a/android_webview/native/aw_contents_background_thread_client.cc
+++ b/android_webview/native/aw_contents_background_thread_client.cc
@@ -6,19 +6,21 @@
#include "jni/AwContentsBackgroundThreadClient_jni.h"
+using base::android::JavaRef;
+
namespace android_webview {
// static
base::android::ScopedJavaLocalRef<jobject>
AwContentsBackgroundThreadClient::shouldInterceptRequest(
JNIEnv* env,
- jobject obj,
- jstring url,
+ const JavaRef<jobject>& obj,
+ const JavaRef<jstring>& url,
jboolean isMainFrame,
jboolean hasUserGesture,
- jstring method,
- jobjectArray requestHeaderNames,
- jobjectArray requestHeaderValues) {
+ const JavaRef<jstring>& method,
+ const JavaRef<jobjectArray>& requestHeaderNames,
+ const JavaRef<jobjectArray>& requestHeaderValues) {
return Java_AwContentsBackgroundThreadClient_shouldInterceptRequestFromNative(
env, obj, url, isMainFrame, hasUserGesture, method, requestHeaderNames,
requestHeaderValues);
« no previous file with comments | « android_webview/native/aw_contents_background_thread_client.h ('k') | android_webview/native/aw_contents_client_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698