Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

Issue 2295693003: DevTools: cleanup WI.NetworkMapping nits (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 this._fileSystemsListContainer = this.containerElement.createChild("div", "" ); 302 this._fileSystemsListContainer = this.containerElement.createChild("div", "" );
303 303
304 this.containerElement.appendChild(createTextButton(WebInspector.UIString("Ad d folder\u2026"), this._addFileSystemClicked.bind(this))); 304 this.containerElement.appendChild(createTextButton(WebInspector.UIString("Ad d folder\u2026"), this._addFileSystemClicked.bind(this)));
305 305
306 /** @type {!Map<string, !Element>} */ 306 /** @type {!Map<string, !Element>} */
307 this._elementByPath = new Map(); 307 this._elementByPath = new Map();
308 308
309 /** @type {!Map<string, !WebInspector.EditFileSystemView>} */ 309 /** @type {!Map<string, !WebInspector.EditFileSystemView>} */
310 this._mappingViewByPath = new Map(); 310 this._mappingViewByPath = new Map();
311 311
312 var fileSystemPaths = WebInspector.isolatedFileSystemManager.fileSystemPaths (); 312 var fileSystems = WebInspector.isolatedFileSystemManager.fileSystems();
313 for (var i = 0; i < fileSystemPaths.length; ++i) 313 for (var i = 0; i < fileSystems.length; ++i)
314 this._addItem(/** @type {!WebInspector.IsolatedFileSystem} */ (WebInspec tor.isolatedFileSystemManager.fileSystem(fileSystemPaths[i]))); 314 this._addItem(fileSystems[i]);
315 } 315 }
316 316
317 WebInspector.WorkspaceSettingsTab.prototype = { 317 WebInspector.WorkspaceSettingsTab.prototype = {
318 /** 318 /**
319 * @return {!Element} 319 * @return {!Element}
320 */ 320 */
321 _createFolderExcludePatternInput: function() 321 _createFolderExcludePatternInput: function()
322 { 322 {
323 var p = createElement("p"); 323 var p = createElement("p");
324 var labelElement = p.createChild("label"); 324 var labelElement = p.createChild("label");
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 return; 573 return;
574 var settings = extension.descriptor()["settings"]; 574 var settings = extension.descriptor()["settings"];
575 if (settings && settings.indexOf(setting.name) !== -1) { 575 if (settings && settings.indexOf(setting.name) !== -1) {
576 InspectorFrontendHost.bringToFront(); 576 InspectorFrontendHost.bringToFront();
577 WebInspector.SettingsScreen._showSettingsScreen(extension.descri ptor()["id"]); 577 WebInspector.SettingsScreen._showSettingsScreen(extension.descri ptor()["id"]);
578 success = true; 578 success = true;
579 } 579 }
580 } 580 }
581 } 581 }
582 } 582 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698