DevTools: cleanup WI.NetworkMapping nits

third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @param {!WebInspector.TargetManager} targetManager
  * @param {!WebInspector.Workspace} workspace
  * @param {!WebInspector.FileSystemWorkspaceBinding} fileSystemWorkspaceBinding
  * @param {!WebInspector.FileSystemMapping} fileSystemMapping
  */
 WebInspector.NetworkMapping = function(targetManager, workspace, fileSystemWorkspaceBinding, fileSystemMapping)
 {
     this._targetManager = targetManager;
     this._workspace = workspace;
     this._fileSystemWorkspaceBinding = fileSystemWorkspaceBinding;
     this._fileSystemMapping = fileSystemMapping;
     InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.RevealSourceLine, this._revealSourceLine, this);
 
     // For now, following block is here primarily for testing since in the real life, network manager is created early enough to capture those events.
     var fileSystemManager = fileSystemWorkspaceBinding.fileSystemManager();
-    for (var path of fileSystemManager.fileSystemPaths()) {
-        var fileSystem = fileSystemManager.fileSystem(path);
-        this._fileSystemAdded(new WebInspector.Event(fileSystemManager, WebInspector.IsolatedFileSystemManager.Events.FileSystemAdded, fileSystem));
-    }
+    for (var fileSystem of fileSystemManager.fileSystems())
+        this._addMappingsForFilesystem(fileSystem);

[dgozman, 2016/08/31 00:08:35]

You don't issue fileSystemMappingChanged here anymore.

[lushnikov, 2016/08/31 00:19:30]

it is an event listener

     if (fileSystemManager.fileSystemsLoaded())
         this._fileSystemsLoaded();
 
     this._eventListeners = [
         fileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemAdded, this._fileSystemAdded, this),
         fileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemRemoved, this._fileSystemRemoved, this),
         fileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemsLoaded, this._fileSystemsLoaded, this),
         this._fileSystemMapping.addEventListener(WebInspector.FileSystemMapping.Events.FileMappingAdded, this._fileSystemMappingChanged, this),
         this._fileSystemMapping.addEventListener(WebInspector.FileSystemMapping.Events.FileMappingRemoved, this._fileSystemMappingChanged, this)
     ];
 }
 
 WebInspector.NetworkMapping.prototype = {
     /**
      * @param {!WebInspector.Event} event
      */
     _fileSystemAdded: function(event)
     {
+        var fileSystem = /** @type {!WebInspector.IsolatedFileSystem} */ (event.data);
+        this._addMappingsForFilesystem(fileSystem);
+        this._fileSystemMappingChanged();
+    },
+
+    /**
+     * @param {!WebInspector.IsolatedFileSystem} fileSystem
+     */
+    _addMappingsForFilesystem: function(fileSystem)
+    {
         this._addingFileSystem = true;
-        var fileSystem = /** @type {!WebInspector.IsolatedFileSystem} */ (event.data);
         this._fileSystemMapping.addFileSystem(fileSystem.path());
 
         var mappings = fileSystem.projectProperty("mappings");
         for (var i = 0; Array.isArray(mappings) && i < mappings.length; ++i) {
             var mapping = mappings[i];
             if (!mapping || typeof mapping !== "object")
                 continue;
             var folder = mapping["folder"];
             var url = mapping["url"];
             if (typeof folder !== "string" || typeof url !== "string")
                 continue;
             this._fileSystemMapping.addNonConfigurableFileMapping(fileSystem.path(), url, folder);
         }
         this._addingFileSystem = false;
-        this._fileSystemMappingChanged();
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _fileSystemRemoved: function(event)
     {
         var fileSystem = /** @type {!WebInspector.IsolatedFileSystem} */ (event.data);
         this._fileSystemMapping.removeFileSystem(fileSystem.path());
         this._fileSystemMappingChanged();
@@ skipping 176 matching lines @@
     dispose: function()
     {
         WebInspector.EventTarget.removeEventListeners(this._eventListeners);
     }
 }
 
 /**
  * @type {!WebInspector.NetworkMapping}
  */
 WebInspector.networkMapping;