Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2295613002: Remove a TODO that is no longer applicable. (Closed)

Created:
4 years, 3 months ago by eroman
Modified:
4 years, 3 months ago
Reviewers:
nharper
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a TODO that is no longer applicable. HKDF was added to the spec trunk: https://github.com/w3c/webcrypto/commit/36bc6686c4cc630a91df3d9e9f38bfc9b8f0ce47 BUG=642045 Committed: https://crrev.com/17c48428872455bc141da64c38567a098f5098e9 Cr-Commit-Position: refs/heads/master@{#415344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
eroman
4 years, 3 months ago (2016-08-30 01:43:07 UTC) #3
nharper
lgtm
4 years, 3 months ago (2016-08-30 17:41:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295613002/1
4 years, 3 months ago (2016-08-30 17:44:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 17:50:13 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 17:51:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17c48428872455bc141da64c38567a098f5098e9
Cr-Commit-Position: refs/heads/master@{#415344}

Powered by Google App Engine
This is Rietveld 408576698