Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: blimp/engine/session/tab.cc

Issue 2295543002: More Blimp browser tests for navigation (Closed)
Patch Set: unused Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/browser_tests/engine_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/session/tab.cc
diff --git a/blimp/engine/session/tab.cc b/blimp/engine/session/tab.cc
index c1a01616296319466c365de07a68b6099e8799a3..69d5db8a16068794ff0308dafc8ea5f04f241119 100644
--- a/blimp/engine/session/tab.cc
+++ b/blimp/engine/session/tab.cc
@@ -75,11 +75,17 @@ void Tab::LoadUrl(const GURL& url) {
}
void Tab::GoBack() {
+ if (!web_contents_->GetController().CanGoBack()) {
Kevin M 2016/08/30 17:28:59 Add DLOG(ERROR) in here so that we call attention
Brian Goldman 2016/08/30 17:52:05 Done.
+ return;
+ }
DVLOG(1) << "Back in tab " << tab_id_;
web_contents_->GetController().GoBack();
}
void Tab::GoForward() {
+ if (!web_contents_->GetController().CanGoForward()) {
+ return;
+ }
DVLOG(1) << "Forward in tab " << tab_id_;
web_contents_->GetController().GoForward();
}
« no previous file with comments | « blimp/engine/browser_tests/engine_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698