Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2295533002: [CUPS] Put the CUPS settings UI behind a command line flag --enable-native-cups. (Closed)

Created:
4 years, 3 months ago by xdai1
Modified:
4 years, 3 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] Put the CUPS settings UI behind a command line flag --enable-native-cups. BUG=626752 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/45862e0e9a07bdba7211f1e130cfd857b7064cc8 Cr-Commit-Position: refs/heads/master@{#415685}

Patch Set 1 #

Patch Set 2 : Fix the trybot failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M chrome/browser/resources/settings/printing_page/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/printing_page.html View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/printing_page.js View 1 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
xdai1
michaelpg@, could you help review this CL please? Thanks!
4 years, 3 months ago (2016-08-29 23:38:38 UTC) #4
michaelpg
lgtm
4 years, 3 months ago (2016-08-31 17:02:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295533002/20001
4 years, 3 months ago (2016-08-31 17:14:22 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 18:25:07 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 18:28:05 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/45862e0e9a07bdba7211f1e130cfd857b7064cc8
Cr-Commit-Position: refs/heads/master@{#415685}

Powered by Google App Engine
This is Rietveld 408576698