Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Issue 2295503002: Don't apply overflow clips in paint invalidation. (Closed)

Created:
4 years, 3 months ago by chrishtr
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Don't apply overflow clips in paint invalidation. Previously, such clips were applied if the paint invalidation container did not scroll overflow, but this is problematic, because overflow:hidden elements can be scrolled via script. BUG=597902, 640565 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2280243002 Cr-Commit-Position: refs/heads/master@{#414951} (cherry picked from commit 537724421c0f5d046e56fb0eba001da3bcea0613) Committed: https://chromium.googlesource.com/chromium/src/+/19e275edf518255cc77cf7fe97d501f536ec87b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/overflow-hidden-yet-scrolled.html View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/overflow-hidden-yet-scrolled-expected.txt View 1 chunk +63 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
chrishtr
4 years, 3 months ago (2016-08-29 21:38:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
19e275edf518255cc77cf7fe97d501f536ec87b7.

Powered by Google App Engine
This is Rietveld 408576698