Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2295483003: CompositingInputsUpdater should do more clip parent analysis (Closed)

Created:
4 years, 3 months ago by trchen
Modified:
4 years, 3 months ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CompositingInputsUpdater should do more clip parent analysis Before this CL the CompositingInputUpdater only perform clip parent analysis if a layer has scrolling ancestor layer. Instead, a layer will need clip parent analysis as long as there is potentially composited clipping ancestor. BUG=630632 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/2ef7df4c03595db39c1b0c303ec8a822f0bf30c9 Cr-Commit-Position: refs/heads/master@{#415440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/compositing/overflow/clip-parent-of-non-scrolled.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/compositing/overflow/clip-parent-of-non-scrolled-expected.html View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
trchen
4 years, 3 months ago (2016-08-30 00:45:23 UTC) #4
Ian Vollick
On 2016/08/30 00:45:23, trchen wrote: This seems very reasonable. LGTM if the bots are happy.
4 years, 3 months ago (2016-08-30 00:52:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295483003/1
4 years, 3 months ago (2016-08-30 21:38:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 21:44:41 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:48:56 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ef7df4c03595db39c1b0c303ec8a822f0bf30c9
Cr-Commit-Position: refs/heads/master@{#415440}

Powered by Google App Engine
This is Rietveld 408576698