Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2295483002: benchmarks: Avoid brackets and commas in test names. (Closed)

Created:
4 years, 3 months ago by jcgregorio
Modified:
4 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

benchmarks: Avoid brackets and commas in test names. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2295483002 Committed: https://skia.googlesource.com/skia/+/1703bd18acd24bc42883b2fcd251bc75a7382d67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M bench/BlurRoundRectBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/PatchBench.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
jcgregorio
4 years, 3 months ago (2016-08-29 19:45:59 UTC) #3
mtklein
lgtm
4 years, 3 months ago (2016-08-29 19:46:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295483002/1
4 years, 3 months ago (2016-08-29 19:46:35 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 20:33:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1703bd18acd24bc42883b2fcd251bc75a7382d67

Powered by Google App Engine
This is Rietveld 408576698