Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2295473002: Move the chromium specific QUIC end-to-end tests from net/quic/core (Closed)

Created:
4 years, 3 months ago by Ryan Hamilton
Modified:
4 years, 3 months ago
Reviewers:
Jana, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, mef
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the chromium specific QUIC end-to-end tests from net/quic/core to net/quic/chromium and make them cross-platform. BUG=641709 Committed: https://crrev.com/e1d19cbf88bf23ce09945335ba25b5a848f87299 Cr-Commit-Position: refs/heads/master@{#415449}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move #

Patch Set 3 : peer #

Patch Set 4 : bug #

Patch Set 5 : Done #

Patch Set 6 : Android #

Patch Set 7 : cronet iOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -436 lines) Patch
M components/cronet/android/test/quic_test_server.cc View 1 2 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download
M components/cronet/ios/test/quic_test_server.cc View 1 2 3 4 5 6 1 chunk +4 lines, -2 lines 0 comments Download
M net/net.gypi View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
A + net/quic/chromium/quic_end_to_end_unittest.cc View 6 chunks +10 lines, -29 lines 0 comments Download
D net/quic/core/quic_end_to_end_unittest.cc View 1 chunk +0 lines, -392 lines 0 comments Download
M net/tools/quic/quic_simple_server.h View 3 chunks +10 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_server.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M net/tools/quic/quic_simple_server_bin.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 43 (31 generated)
Ryan Hamilton
4 years, 3 months ago (2016-08-29 18:59:29 UTC) #3
Jana
lgtm Thank you for doing this! Echoing one nit that you pointed out, but LGTM ...
4 years, 3 months ago (2016-08-29 19:14:53 UTC) #5
Ryan Hamilton
Thanks https://codereview.chromium.org/2295473002/diff/1/net/net.gypi File net/net.gypi (right): https://codereview.chromium.org/2295473002/diff/1/net/net.gypi#newcode1888 net/net.gypi:1888: 'tools/quic/chlo_extractor_test.cc', On 2016/08/29 19:14:53, Jana wrote: > Add ...
4 years, 3 months ago (2016-08-29 19:17:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295473002/80001
4 years, 3 months ago (2016-08-30 13:50:45 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/132864)
4 years, 3 months ago (2016-08-30 14:02:02 UTC) #22
Ryan Hamilton
xunjieli: components/cronet/, please.
4 years, 3 months ago (2016-08-30 17:52:18 UTC) #26
xunjieli
On 2016/08/30 17:52:18, Ryan Hamilton wrote: > xunjieli: components/cronet/, please. Could you update the iOS ...
4 years, 3 months ago (2016-08-30 19:19:48 UTC) #29
Ryan Hamilton
On 2016/08/30 19:19:48, xunjieli wrote: > On 2016/08/30 17:52:18, Ryan Hamilton wrote: > > xunjieli: ...
4 years, 3 months ago (2016-08-30 20:39:50 UTC) #31
xunjieli
(+mef: FYI) LGTM.
4 years, 3 months ago (2016-08-30 21:09:08 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295473002/120001
4 years, 3 months ago (2016-08-30 21:55:43 UTC) #39
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 3 months ago (2016-08-30 22:02:02 UTC) #41
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 22:05:30 UTC) #43
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/e1d19cbf88bf23ce09945335ba25b5a848f87299
Cr-Commit-Position: refs/heads/master@{#415449}

Powered by Google App Engine
This is Rietveld 408576698