Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2295463002: [NOT FOR REVIEW] use cominbed clip for visible rect calculation

Created:
4 years, 3 months ago by weiliangc
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NOT FOR REVIEW] use cominbed clip for visible rect calculation Different patchset are all intermediate step to match behavior with calculating visible rects by simply combining all clips. This helps identify edge cases to whether that behavior is correct. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Patch Set 1 : use combined_clip instead of clip when target is not clipped #

Patch Set 2 : skip bringing layer bounds to target space #

Patch Set 3 : always use combined clip in target space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -66 lines) Patch
M cc/trees/draw_property_utils.cc View 1 2 2 chunks +2 lines, -66 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
weiliangc
Patch Set 1 failures: 3 tests failed: LayerTreeHostCommonTest.DrawableAndVisibleRectsWhenCannotRenderToSeparateSurface (../../cc/trees/layer_tree_host_common_unittest.cc:3206) LayerTreeHostCommonTest.RootClipPropagationToClippedSurface (../../cc/trees/layer_tree_host_common_unittest.cc:3931) LayerTreeHostCommonTest.VisibleRectsForClippedDescendantsOfUnclippedSurfaces (../../cc/trees/layer_tree_host_common_unittest.cc:3775)
4 years, 3 months ago (2016-08-29 18:58:10 UTC) #2
weiliangc
On 2016/08/29 18:58:10, weiliangc wrote: > Patch Set 1 failures: > 3 tests failed: > ...
4 years, 3 months ago (2016-08-29 18:59:54 UTC) #3
weiliangc
On 2016/08/29 at 18:59:54, weiliangc wrote: > On 2016/08/29 18:58:10, weiliangc wrote: > > Patch ...
4 years, 3 months ago (2016-08-29 19:11:58 UTC) #4
weiliangc
4 years, 3 months ago (2016-08-29 19:18:12 UTC) #5 
On 2016/08/29 at 19:11:58, weiliangc wrote:
> On 2016/08/29 at 18:59:54, weiliangc wrote:
> > On 2016/08/29 18:58:10, weiliangc wrote:
> > > Patch Set 1 failures:
> > > 3 tests failed:
> > >    
> > >
LayerTreeHostCommonTest.DrawableAndVisibleRectsWhenCannotRenderToSeparateSurface
> > > (../../cc/trees/layer_tree_host_common_unittest.cc:3206)
> > >     LayerTreeHostCommonTest.RootClipPropagationToClippedSurface
> > > (../../cc/trees/layer_tree_host_common_unittest.cc:3931)
> > >    
LayerTreeHostCommonTest.VisibleRectsForClippedDescendantsOfUnclippedSurfaces
> > > (../../cc/trees/layer_tree_host_common_unittest.cc:3775)
> > 
> > Possibly related bug: crbug.com/581844 (Not clear accumulated clip when
reaching unclipped surface)
> 
> Patch set 2 failed:
> 5 tests failed:
>    
LayerTreeHostCommonTest.DrawableAndVisibleRectsWhenCannotRenderToSeparateSurface
(../../cc/trees/layer_tree_host_common_unittest.cc:3206)
>     LayerTreeHostCommonTest.LayerFullyContainedWithinClipInTargetSpace
(../../cc/trees/layer_tree_host_common_unittest.cc:1169)
>     LayerTreeHostCommonTest.RootClipPropagationToClippedSurface
(../../cc/trees/layer_tree_host_common_unittest.cc:3931)
>    
LayerTreeHostCommonTest.VisibleContentRectForAnimatedLayerWithSingularTransform
(../../cc/trees/layer_tree_host_common_unittest.cc:7939)
>    
LayerTreeHostCommonTest.VisibleRectsForClippedDescendantsOfUnclippedSurfaces
(../../cc/trees/layer_tree_host_common_unittest.cc:3775)
> 
> The code use to bring layer bounds into target space, intersect, and bring
intersection back to layer space, and intersect with layer bounds. This patch
set skips the first part, so possibly just numeric mismatch.

Patch set 3 failed:
9 tests failed:
    LayerTreeHostCommonTest.ClipChildVisibleRect
(../../cc/trees/layer_tree_host_common_unittest.cc:9130)
    LayerTreeHostCommonTest.ClipParentScrolledInterveningLayer
(../../cc/trees/layer_tree_host_common_unittest.cc:5758)
    LayerTreeHostCommonTest.ClipParentWithInterveningRenderSurface
(../../cc/trees/layer_tree_host_common_unittest.cc:5678)
   
LayerTreeHostCommonTest.DrawableAndVisibleRectsWhenCannotRenderToSeparateSurface
(../../cc/trees/layer_tree_host_common_unittest.cc:3206)
    LayerTreeHostCommonTest.LayerFullyContainedWithinClipInTargetSpace
(../../cc/trees/layer_tree_host_common_unittest.cc:1169)
    LayerTreeHostCommonTest.RootClipPropagationToClippedSurface
(../../cc/trees/layer_tree_host_common_unittest.cc:3931)
    LayerTreeHostCommonTest.ScrollChildAndScrollParentDifferentTargets
(../../cc/trees/layer_tree_host_common_unittest.cc:6348)
   
LayerTreeHostCommonTest.VisibleContentRectForAnimatedLayerWithSingularTransform
(../../cc/trees/layer_tree_host_common_unittest.cc:7939)
    LayerTreeHostCommonTest.VisibleRectsForClippedDescendantsOfUnclippedSurfaces
(../../cc/trees/layer_tree_host_common_unittest.cc:3775)

This patch set always uses combined clip (when non-root surfaces enabled), and
should have results fairly close to calculate clips dynamically.

Powered by Google App Engine
This is Rietveld 408576698