Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2295443002: X11: Don't Activate() on Show() (Closed)

Created:
4 years, 3 months ago by Tom (Use chromium acct)
Modified:
4 years, 3 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

X11: Don't Activate() on Show() CL 08b6593d added a workaround to make focus work in the case of no window manager. This is no longer necessary now that the new focus-tracking algorithm keeps track of has_pointer_focus_. BUG=546854 Committed: https://crrev.com/4cca65aee455e81c8665120fdf3fc8a31d369afd Cr-Commit-Position: refs/heads/master@{#415421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Tom (Use chromium acct)
4 years, 3 months ago (2016-08-29 18:26:28 UTC) #3
Elliot Glaysher
lgtm
4 years, 3 months ago (2016-08-30 19:43:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295443002/1
4 years, 3 months ago (2016-08-30 20:00:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 20:57:02 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 20:58:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cca65aee455e81c8665120fdf3fc8a31d369afd
Cr-Commit-Position: refs/heads/master@{#415421}

Powered by Google App Engine
This is Rietveld 408576698