Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2295433003: Changes around how browser_tests are launched for mash (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
Elliot Glaysher, sadrul
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes around how browser_tests are launched for mash This does roughly the same thing as we do for chrome --mash. In particular it bundles the all the mash apps so that we aren't dll opening them as that causes problems. BUG=594674 TEST=covered by tests. TBR=erg@chromium.org Committed: https://crrev.com/e7cc53efdf3b5981c1a01bc1f1dc1dbf658108b8 Cr-Commit-Position: refs/heads/master@{#415329}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : cleanup #

Patch Set 4 : make manifest chromeos specific #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -161 lines) Patch
M chrome/app/mash/BUILD.gn View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 6 chunks +3 lines, -82 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 chunks +40 lines, -4 lines 0 comments Download
M chrome/test/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/browser_tests_main.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
A + chrome/test/base/browser_tests_main_chromeos.cc View 1 2 chunks +1 line, -6 lines 0 comments Download
M chrome/test/base/mash_browser_tests_main.cc View 1 2 7 chunks +33 lines, -13 lines 0 comments Download
A + chrome/test/base/mash_browser_tests_manifest.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/mojo_test_connector.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/test/base/mojo_test_connector.cc View 1 2 2 chunks +49 lines, -38 lines 0 comments Download
A mash/package/BUILD.gn View 1 chunk +27 lines, -0 lines 0 comments Download
A mash/package/DEPS View 1 1 chunk +6 lines, -0 lines 0 comments Download
A mash/package/mash_packaged_service.h View 1 1 chunk +51 lines, -0 lines 0 comments Download
A mash/package/mash_packaged_service.cc View 1 1 chunk +77 lines, -0 lines 0 comments Download
M services/ui/service.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 23 (14 generated)
sky
erg: adds DEP to font_service from mash/package/DEPS sadrul: the rest
4 years, 3 months ago (2016-08-29 22:54:42 UTC) #5
sky
I made this chromeos specific as that simplifies things, and at least in the short ...
4 years, 3 months ago (2016-08-29 23:30:31 UTC) #7
sadrul
Interesting! lgtm
4 years, 3 months ago (2016-08-30 16:01:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295433003/60001
4 years, 3 months ago (2016-08-30 16:33:22 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/249288)
4 years, 3 months ago (2016-08-30 16:39:02 UTC) #15
sky
TBR erg for DEPS.
4 years, 3 months ago (2016-08-30 16:51:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295433003/60001
4 years, 3 months ago (2016-08-30 16:58:16 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-30 17:02:46 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 17:06:06 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e7cc53efdf3b5981c1a01bc1f1dc1dbf658108b8
Cr-Commit-Position: refs/heads/master@{#415329}

Powered by Google App Engine
This is Rietveld 408576698