Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Issue 2295433002: chromeos: Remove unused peerd D-Bus client libraries (Closed)

Created:
4 years, 3 months ago by James Cook
Modified:
4 years, 3 months ago
Reviewers:
stevenjb, dtapuska
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Remove unused peerd D-Bus client libraries These are unused and no longer needed. We can revive them from git history if we need them again. BUG=641996 TEST=compiles Committed: https://crrev.com/4ee192b5dee4fdc94fbafd8964546d8b0a7613df Cr-Commit-Position: refs/heads/master@{#415226}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -798 lines) Patch
M chromeos/chromeos.gyp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chromeos/dbus/README.md View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/dbus_client_bundle.h View 1 4 chunks +1 line, -8 lines 0 comments Download
M chromeos/dbus/dbus_client_bundle.cc View 1 4 chunks +0 lines, -8 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.h View 1 3 chunks +0 lines, -4 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 1 4 chunks +0 lines, -12 lines 0 comments Download
D chromeos/dbus/fake_peer_daemon_manager_client.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chromeos/dbus/fake_peer_daemon_manager_client.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D chromeos/dbus/peer_daemon_manager_client.h View 1 chunk +0 lines, -202 lines 0 comments Download
D chromeos/dbus/peer_daemon_manager_client.cc View 1 chunk +0 lines, -429 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
James Cook
dtapuska, please take a look.
4 years, 3 months ago (2016-08-29 17:43:39 UTC) #3
dtapuska
lgtm
4 years, 3 months ago (2016-08-29 19:28:41 UTC) #5
James Cook
stevenjb, can I get OWNERS?
4 years, 3 months ago (2016-08-29 19:47:27 UTC) #7
stevenjb
RS LGTM
4 years, 3 months ago (2016-08-29 20:58:12 UTC) #8
Ben Chan
On 2016/08/29 20:58:12, stevenjb wrote: > RS LGTM fyi, privetd binding was removed in https://crrev.com/48a9459b9f1de00b2ca2540ae9f6273d6cce67cf. ...
4 years, 3 months ago (2016-08-29 22:08:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295433002/20001
4 years, 3 months ago (2016-08-30 05:30:54 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 06:31:23 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:33:53 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ee192b5dee4fdc94fbafd8964546d8b0a7613df
Cr-Commit-Position: refs/heads/master@{#415226}

Powered by Google App Engine
This is Rietveld 408576698