Detach LeakDetectorController from remote controller on shutdown

Detach LeakDetectorController from remote controller on shutdown

Fix an invalid pointer dereference during browser process shutdown,
where LeakDetectorController::OnRemoteProcessShutdown is called
after the LeakDetectorController has already been deleted.

BUG=chromium:637131
TEST=run with leak detector enabled, make sure no crash happens on
shutdown; i.e. no attempts to call OnRemoteProcessShutdown() after
LeakDetectorController has been destroyed.

Committed: https://crrev.com/79f2cd96c247cac4a90708aa7ca86bb48a34c8a2
Cr-Commit-Position: refs/heads/master@{#416381}

[Simon Que, 2016-08-31 21:51:50]

sque@chromium.org changed reviewers:
+ wfh@chromium.org, yzshen@chromium.org

[yzshen1, 2016-09-02 15:40:03]

LGTM as long as the owner is happy with this.

[Will Harris, 2016-09-02 16:23:07]

lgtm

[Simon Que, 2016-09-02 17:14:25]

The CQ bit was checked by sque@chromium.org

[commit-bot: I haz the power, 2016-09-02 17:14:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 17:53:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 17:53:54]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Simon Que, 2016-09-02 22:13:29]

The CQ bit was checked by sque@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 22:14:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 22:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 22:59:35]

Dry run: This issue passed the CQ dry run.

[Simon Que, 2016-09-02 23:12:52]

The CQ bit was checked by sque@chromium.org

[Simon Que, 2016-09-02 23:12:53]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org,
wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/2295413002/#ps20001
(title: "Fix for unit testing")

[commit-bot: I haz the power, 2016-09-02 23:13:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 23:17:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-02 23:20:55]

Description was changed from

==========
Detach LeakDetectorController from remote controller on shutdown

Fix an invalid pointer dereference during browser process shutdown,
where LeakDetectorController::OnRemoteProcessShutdown is called
after the LeakDetectorController has already been deleted.

BUG=chromium:637131
TEST=run with leak detector enabled, make sure no crash happens on
shutdown; i.e. no attempts to call OnRemoteProcessShutdown() after
LeakDetectorController has been destroyed.
==========

to

==========
Detach LeakDetectorController from remote controller on shutdown

Fix an invalid pointer dereference during browser process shutdown,
where LeakDetectorController::OnRemoteProcessShutdown is called
after the LeakDetectorController has already been deleted.

BUG=chromium:637131
TEST=run with leak detector enabled, make sure no crash happens on
shutdown; i.e. no attempts to call OnRemoteProcessShutdown() after
LeakDetectorController has been destroyed.

Committed: https://crrev.com/79f2cd96c247cac4a90708aa7ca86bb48a34c8a2
Cr-Commit-Position: refs/heads/master@{#416381}
==========

[commit-bot: I haz the power, 2016-09-02 23:20:56]

Patchset 2 (id:??) landed as
https://crrev.com/79f2cd96c247cac4a90708aa7ca86bb48a34c8a2
Cr-Commit-Position: refs/heads/master@{#416381}