Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2295403003: Revert of [chromedriver] Remove invalid assertions from tests. (Closed)

Created:
4 years, 3 months ago by samuong
Modified:
4 years, 3 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [chromedriver] Remove invalid assertions from tests. (patchset #1 id:1 of https://codereview.chromium.org/2299723002/ ) Reason for revert: reverting in favor of crrev.com/415873, which fixes the way we handle background pages from devtools Original issue's description: > [chromedriver] Remove invalid assertions from tests. > > These tests assume that no extension background pages have loaded at the start > of the test, but for some reason DevTools is reporting these earlier than it > used to. It's valid to have these background pages in the window list, so I've > removed the assertions. > > BUG= > TBR=stgao@chromium.org > > Committed: https://crrev.com/e6877e7e07e21d42dc1fb57184c0ff2851b9e859 > Cr-Commit-Position: refs/heads/master@{#415701} TBR=stgao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/ef5c7f595363bcca04c96cb5e7d02d6a764e2c91 Cr-Commit-Position: refs/heads/master@{#415976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
samuong
Created Revert of [chromedriver] Remove invalid assertions from tests.
4 years, 3 months ago (2016-09-01 16:55:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295403003/1
4 years, 3 months ago (2016-09-01 16:55:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 16:56:54 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 17:00:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef5c7f595363bcca04c96cb5e7d02d6a764e2c91
Cr-Commit-Position: refs/heads/master@{#415976}

Powered by Google App Engine
This is Rietveld 408576698