🔔 Allow android_* targets to specify proguard flags for apks

Allow android_* targets to specify proguard flags for apks

There are two current places where this comes up: play services and gvr.
Both have been updated in this change to use the new variable.

Follow-up change will be made to remove the play-services-specific -keep
from base/android/base_proguard_config.flags.new once downstream has
updated to use this new flag as well.

This does not yet support detecting proguard.flags file within an .aar.
That will come later as well.

TBR=bshe
BUG=640836
Committed: https://crrev.com/aeb5a420fe3017cf81b0fb23770edf51238623c5
Cr-Commit-Position: refs/heads/master@{#415962}

[agrieve, 2016-08-31 20:42:56]

agrieve@chromium.org changed reviewers:
+ bshe@chromium.org, ianwen@chromium.org

[agrieve, 2016-08-31 20:42:56]

bshe@chromium.org: Please review changes in gvr

ianwen: Please review all else

[Ian Wen, 2016-09-01 01:31:55]

lgtm

There is a lot of argument plumbing going on. :)

https://codereview.chromium.org/2295363002/diff/1/build/android/gyp/write_bui...
File build/android/gyp/write_build_config.py (right):

https://codereview.chromium.org/2295363002/diff/1/build/android/gyp/write_bui...
build/android/gyp/write_build_config.py:282: help='GYP-list of proguard flag
files to use in final apk.')
Q: do we have plans to rename GYP-list to GN-list in future?

[agrieve, 2016-09-01 14:06:02]

Description was changed from

==========
Allow android_* targets to specify proguard flags for apks

There are two current places where this comes up: play services and gvr.
Both have been updated in this change to use the new variable.

Follow-up change will be made to remove the play-services-specific -keep
from base/android/base_proguard_config.flags.new once downstream has
updated to use this new flag as well.

This does not yet support detecting proguard.flags file within an .aar.
That will come later as well.

BUG=640836
==========

to

==========
Allow android_* targets to specify proguard flags for apks

There are two current places where this comes up: play services and gvr.
Both have been updated in this change to use the new variable.

Follow-up change will be made to remove the play-services-specific -keep
from base/android/base_proguard_config.flags.new once downstream has
updated to use this new flag as well.

This does not yet support detecting proguard.flags file within an .aar.
That will come later as well.

TBR=bshe
BUG=640836
==========

[agrieve, 2016-09-01 14:06:43]

On 2016/09/01 01:31:55, Ian Wen wrote:
> lgtm
> 
> There is a lot of argument plumbing going on. :)
> 
>
https://codereview.chromium.org/2295363002/diff/1/build/android/gyp/write_bui...
> File build/android/gyp/write_build_config.py (right):
> 
>
https://codereview.chromium.org/2295363002/diff/1/build/android/gyp/write_bui...
> build/android/gyp/write_build_config.py:282: help='GYP-list of proguard flag
> files to use in final apk.')
> Q: do we have plans to rename GYP-list to GN-list in future?

Looks like Biao is OOO until next week. TBR'ing the one line in gvr-android-sdk.

[agrieve, 2016-09-01 14:07:09]

https://codereview.chromium.org/2295363002/diff/1/build/android/gyp/write_bui...
File build/android/gyp/write_build_config.py (right):

https://codereview.chromium.org/2295363002/diff/1/build/android/gyp/write_bui...
build/android/gyp/write_build_config.py:282: help='GYP-list of proguard flag
files to use in final apk.')
On 2016/09/01 01:31:55, Ian Wen wrote:
> Q: do we have plans to rename GYP-list to GN-list in future?

We definitely should :)

[agrieve, 2016-09-01 14:07:13]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-09-01 14:07:26]

The CQ bit was unchecked by commit-bot@chromium.org

[agrieve, 2016-09-01 14:07:27]

The CQ bit was unchecked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-09-01 14:07:27]

This CL has an open dependency (Issue 2302533002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[agrieve, 2016-09-01 14:46:25]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-09-01 14:46:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 15:45:20]

Description was changed from

==========
Allow android_* targets to specify proguard flags for apks

There are two current places where this comes up: play services and gvr.
Both have been updated in this change to use the new variable.

Follow-up change will be made to remove the play-services-specific -keep
from base/android/base_proguard_config.flags.new once downstream has
updated to use this new flag as well.

This does not yet support detecting proguard.flags file within an .aar.
That will come later as well.

TBR=bshe
BUG=640836
==========

to

==========
Allow android_* targets to specify proguard flags for apks

There are two current places where this comes up: play services and gvr.
Both have been updated in this change to use the new variable.

Follow-up change will be made to remove the play-services-specific -keep
from base/android/base_proguard_config.flags.new once downstream has
updated to use this new flag as well.

This does not yet support detecting proguard.flags file within an .aar.
That will come later as well.

TBR=bshe
BUG=640836
==========

[commit-bot: I haz the power, 2016-09-01 15:45:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-01 15:49:33]

Description was changed from

==========
Allow android_* targets to specify proguard flags for apks

There are two current places where this comes up: play services and gvr.
Both have been updated in this change to use the new variable.

Follow-up change will be made to remove the play-services-specific -keep
from base/android/base_proguard_config.flags.new once downstream has
updated to use this new flag as well.

This does not yet support detecting proguard.flags file within an .aar.
That will come later as well.

TBR=bshe
BUG=640836
==========

to

==========
Allow android_* targets to specify proguard flags for apks

There are two current places where this comes up: play services and gvr.
Both have been updated in this change to use the new variable.

Follow-up change will be made to remove the play-services-specific -keep
from base/android/base_proguard_config.flags.new once downstream has
updated to use this new flag as well.

This does not yet support detecting proguard.flags file within an .aar.
That will come later as well.

TBR=bshe
BUG=640836

Committed: https://crrev.com/aeb5a420fe3017cf81b0fb23770edf51238623c5
Cr-Commit-Position: refs/heads/master@{#415962}
==========

[commit-bot: I haz the power, 2016-09-01 15:49:34]

Patchset 1 (id:??) landed as
https://crrev.com/aeb5a420fe3017cf81b0fb23770edf51238623c5
Cr-Commit-Position: refs/heads/master@{#415962}