Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2295323004: Fix |g_all_pools_state| data race by using atomics. (Closed)

Created:
4 years, 3 months ago by gab
Modified:
4 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix |g_all_pools_state| data race by using atomics. And change a few checks from != NONE_ACTIVE to == WORKER_CREATED where it's guaranteed (i.e. in code that can only run after a Worker is created). BUG=639812 Committed: https://crrev.com/edb053ea0f3192d89926a1f1fa50747ec00fa078 Cr-Commit-Position: refs/heads/master@{#416250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -26 lines) Patch
M base/threading/sequenced_worker_pool.cc View 22 chunks +58 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
gab
Dana PTAL (see bug for discussion, specifically comments #8-11).
4 years, 3 months ago (2016-09-01 15:06:52 UTC) #4
danakj
LGTM
4 years, 3 months ago (2016-09-02 00:14:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295323004/1
4 years, 3 months ago (2016-09-02 13:00:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 13:04:10 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 13:06:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edb053ea0f3192d89926a1f1fa50747ec00fa078
Cr-Commit-Position: refs/heads/master@{#416250}

Powered by Google App Engine
This is Rietveld 408576698