third_party: Update remote shell protocol to version 2

third_party: Update remote shell protocol to version 2

The new requests enable the compositor to distinguish between dragging
and other geometry updates, which is needed for window positioning in
extended desktop mode.

BUG=642894
TEST=None

Committed: https://crrev.com/9bcc88b35dd3801e705b80cc46133f8221d39e15
Cr-Commit-Position: refs/heads/master@{#421340}

[Dominik Laskowski, 2016-08-31 21:14:44]

The CQ bit was checked by domlaskowski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 21:15:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dominik Laskowski, 2016-08-31 21:19:52]

domlaskowski@chromium.org changed reviewers:
+ oshima@chromium.org, reveman@chromium.org

[Dominik Laskowski, 2016-08-31 21:19:53]

PTAL.

[commit-bot: I haz the power, 2016-08-31 22:04:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 22:04:27]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-09-02 14:37:22]

https://codereview.chromium.org/2295323003/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2295323003/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:542:
</request>
Chrome side may also have to abort drag (activation change changed during,
system modal might shown etc), so I think you need to add an event for that
case.

[reveman, 2016-09-02 14:59:25]

https://codereview.chromium.org/2295323003/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2295323003/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:527:
<request name="drag" since="12">
Please use similar language as the xdg spec. ie. "interactive, user-driven move
of the surface. " instead of "drag".

And to make the request names match other requests that toggle compositor side
state I think set_moving/unset_moving would be good. wdyt?

https://codereview.chromium.org/2295323003/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:541:
<arg name="revert" type="uint"/>
what is this argument supposed to be used for by the compositor?

[Dominik Laskowski, 2016-09-15 20:07:26]

Sorry for the delay. I've been addressing edge cases, and dealing with unrelated
pointer/DPI/rotation/layout issues.

https://codereview.chromium.org/2295323003/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2295323003/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:527:
<request name="drag" since="12">
On 2016/09/02 14:59:25, reveman wrote:
> Please use similar language as the xdg spec. ie. "interactive, user-driven
move
> of the surface. " instead of "drag".
> 
> And to make the request names match other requests that toggle compositor side
> state I think set_moving/unset_moving would be good. wdyt?
> 

Done.

https://codereview.chromium.org/2295323003/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:541:
<arg name="revert" type="uint"/>
On 2016/09/02 14:59:25, reveman wrote:
> what is this argument supposed to be used for by the compositor?

If the drag is reverted after entering another display, there is no need for the
compositor to move the window to that display, because the next
set_window_geometry request will move it back.

However, all cases that require a revert are detected by the server before the
client, so this argument is unnecessary. The only such cases are display
configuration changes, e.g. unplugging a display while dragging. Previously, a
client-side ACTION_CANCEL input event would also revert the drag, but it only
seems to happen on window deactivation and Ash just drops the window in that
case [1]. The next patch in ag/1396283 will address this.

[1]
https://chromium.googlesource.com/chromium/src/+/master/ash/common/wm/wm_topl...

https://codereview.chromium.org/2295323003/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:542:
</request>
On 2016/09/02 14:37:21, oshima wrote:
> Chrome side may also have to abort drag (activation change changed during,
> system modal might shown etc), so I think you need to add an event for that
> case.

The client can detect all cases that require aborting the drag, i.e. window
deactivation and display configuration changes. The only other case is window
destruction, which is handled by the server.

[reveman, 2016-09-21 02:55:43]

lgtm after rebase on tot where zwp_remote_shell has been replaced by
zcr_remote_shell and zwp_remote_shell is deprecated.

[Dominik Laskowski, 2016-09-22 22:37:12]

Description was changed from

==========
third_party: Update to version 12 of remote_shell_protocol

The new requests enable the compositor to distinguish between dragging
and other geometry updates, which is needed for window positioning in
extended desktop mode.

BUG=642894
TEST=None
==========

to

==========
third_party: Update remote shell protocol to version 2

The new requests enable the compositor to distinguish between dragging
and other geometry updates, which is needed for window positioning in
extended desktop mode.

BUG=642894
TEST=None
==========

[Dominik Laskowski, 2016-09-27 21:05:13]

The CQ bit was checked by domlaskowski@chromium.org

[Dominik Laskowski, 2016-09-27 21:05:14]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2295323003/#ps60001
(title: "Migrate to "zcr" interfaces")

[commit-bot: I haz the power, 2016-09-27 21:05:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 21:30:24]

Description was changed from

==========
third_party: Update remote shell protocol to version 2

The new requests enable the compositor to distinguish between dragging
and other geometry updates, which is needed for window positioning in
extended desktop mode.

BUG=642894
TEST=None
==========

to

==========
third_party: Update remote shell protocol to version 2

The new requests enable the compositor to distinguish between dragging
and other geometry updates, which is needed for window positioning in
extended desktop mode.

BUG=642894
TEST=None
==========

[commit-bot: I haz the power, 2016-09-27 21:30:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-27 21:31:48]

Description was changed from

==========
third_party: Update remote shell protocol to version 2

The new requests enable the compositor to distinguish between dragging
and other geometry updates, which is needed for window positioning in
extended desktop mode.

BUG=642894
TEST=None
==========

to

==========
third_party: Update remote shell protocol to version 2

The new requests enable the compositor to distinguish between dragging
and other geometry updates, which is needed for window positioning in
extended desktop mode.

BUG=642894
TEST=None

Committed: https://crrev.com/9bcc88b35dd3801e705b80cc46133f8221d39e15
Cr-Commit-Position: refs/heads/master@{#421340}
==========

[commit-bot: I haz the power, 2016-09-27 21:31:49]

Patchset 4 (id:??) landed as
https://crrev.com/9bcc88b35dd3801e705b80cc46133f8221d39e15
Cr-Commit-Position: refs/heads/master@{#421340}