Download Drop Down Highlight Doesn't Stay

Download Drop Down Highlight Doesn't Stay

The highlight animations for download item views was being posted to a
non-nested loop. This allowed them to clear after returning from a blocking
menu call.

Menus do not block now. Updating the animations to register a callback
with DownloadShelfContextMenuView so that they can clear the highlight
once the menu has closed.

TEST=manually test download visuals
BUG=642672
Committed: https://crrev.com/45988867f91690d8ff0d68ce52e171bf74944926
Cr-Commit-Position: refs/heads/master@{#415778}

[jonross, 2016-08-31 19:59:45]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2016-08-31 19:59:45]

Hey sky@

Could you take a look at this regression fix? Had to update a non-nested
post-task to be a callback once menus are closed.

Thanks,
Jon

[sky, 2016-08-31 21:16:19]

LGTM

[jonross, 2016-08-31 21:30:58]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-08-31 21:31:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 22:19:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-31 22:22:24]

Description was changed from

==========
Download Drop Down Highlight Doesn't Stay

The highlight animations for download item views was being posted to a
non-nested loop. This allowed them to clear after returning from a blocking
menu call.

Menus do not block now. Updating the animations to register a callback
with DownloadShelfContextMenuView so that they can clear the highlight
once the menu has closed.

TEST=manually test download visuals
BUG=642672
==========

to

==========
Download Drop Down Highlight Doesn't Stay

The highlight animations for download item views was being posted to a
non-nested loop. This allowed them to clear after returning from a blocking
menu call.

Menus do not block now. Updating the animations to register a callback
with DownloadShelfContextMenuView so that they can clear the highlight
once the menu has closed.

TEST=manually test download visuals
BUG=642672

Committed: https://crrev.com/45988867f91690d8ff0d68ce52e171bf74944926
Cr-Commit-Position: refs/heads/master@{#415778}
==========

[commit-bot: I haz the power, 2016-08-31 22:22:25]

Patchset 1 (id:??) landed as
https://crrev.com/45988867f91690d8ff0d68ce52e171bf74944926
Cr-Commit-Position: refs/heads/master@{#415778}