Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2295273002: Remove comment from FontConfigIPC::makeTypeface. (Closed)

Created:
4 years, 3 months ago by bungeman-chromium
Modified:
4 years, 3 months ago
Reviewers:
drott, dcheng
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove comment from FontConfigIPC::makeTypeface. The documentation comment for FontConfigIPC::makeTypeface is now somewhat confusing because it is about the previous signature of this method. Previously this method returned SkTypeface* and the ownership of the reference was ambiguous in the code but specified by the documentation comment. Now the code specifies the ownership semantics explicitly by returning a smart pointer, so the comment is no longer needed. Committed: https://crrev.com/e879fee10fc6b7ec2e1fd224327652d6038f832a Cr-Commit-Position: refs/heads/master@{#415713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/common/font_config_ipc_linux.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
bungeman-chromium
I've had a tab open for about three months now with drott's comment that this ...
4 years, 3 months ago (2016-08-31 18:11:54 UTC) #5
dcheng
rs lgtm
4 years, 3 months ago (2016-08-31 18:12:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295273002/1
4 years, 3 months ago (2016-08-31 18:15:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 19:12:09 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e879fee10fc6b7ec2e1fd224327652d6038f832a Cr-Commit-Position: refs/heads/master@{#415713}
4 years, 3 months ago (2016-08-31 19:14:30 UTC) #13
drott
4 years, 3 months ago (2016-09-02 09:54:41 UTC) #14
Message was sent while issue was closed.
Thx.

Powered by Google App Engine
This is Rietveld 408576698