Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 2295233002: [layoutng] fix incorrect vector sizing (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] fix incorrect vector sizing We need to set the capacity, not the size, to children_.size() because otherwise the following append() calls will not do the right thing. R=eae@chromium.org, ikilpatrick@chromium.org, glebl@chromium.org BUG=635619 Committed: https://chromium.googlesource.com/chromium/src/+/7cd22eaca633bf31c2c3ce11ebe7faefb85dd551

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
cbiesinger
4 years, 3 months ago (2016-08-31 17:10:28 UTC) #1
ikilpatrick
lgtm, thanks for fixing my silly mistakes. :)
4 years, 3 months ago (2016-08-31 17:13:36 UTC) #4
eae
LGTM
4 years, 3 months ago (2016-08-31 17:17:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295233002/1
4 years, 3 months ago (2016-08-31 17:18:48 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7cd22eaca633bf31c2c3ce11ebe7faefb85dd551 Cr-Commit-Position: refs/heads/master@{#415721}
4 years, 3 months ago (2016-08-31 19:24:09 UTC) #10
cbiesinger
4 years, 3 months ago (2016-08-31 19:25:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7cd22eaca633bf31c2c3ce11ebe7faefb85dd551 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698