Update desktop tree when Aura windows are removed.

chrome/browser/ui/aura/accessibility/automation_manager_aura.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/aura/accessibility/automation_manager_aura.h"
 
 #include <stddef.h>
 
 #include <vector>
 
 #include "base/memory/singleton.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/api/automation_internal/automation_event_router.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/common/extensions/chrome_extension_messages.h"
 #include "content/public/browser/ax_event_notification_details.h"
 #include "content/public/browser/browser_context.h"
 #include "ui/aura/window.h"
-#include "ui/views/accessibility/ax_aura_obj_cache.h"
 #include "ui/views/accessibility/ax_aura_obj_wrapper.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 
 #if defined(OS_CHROMEOS)
 #include "ash/wm/window_util.h"  // nogncheck
 #endif
 
 using content::BrowserContext;
 using extensions::AutomationEventRouter;
 
 // static
 AutomationManagerAura* AutomationManagerAura::GetInstance() {
   return base::Singleton<AutomationManagerAura>::get();
 }
 
 void AutomationManagerAura::Enable(BrowserContext* context) {
   enabled_ = true;
   if (!current_tree_.get())
     current_tree_.reset(new AXTreeSourceAura());
   ResetSerializer();
 
   SendEvent(context, current_tree_->GetRoot(), ui::AX_EVENT_LOAD_COMPLETE);
+  views::AXAuraObjCache::GetInstance()->SetDelegate(this);
 
 #if defined(OS_CHROMEOS)
   aura::Window* active_window = ash::wm::GetActiveWindow();
   if (active_window) {
     views::AXAuraObjWrapper* focus =
         views::AXAuraObjCache::GetInstance()->GetOrCreate(active_window);
     SendEvent(context, focus, ui::AX_EVENT_CHILDREN_CHANGED);
   }
 #endif
 }
@@ skipping 60 matching lines @@
     return;
   }
   current_tree_->SetSelection(anchor_id, anchor_offset, focus_offset);
 }
 
 void AutomationManagerAura::ShowContextMenu(int32_t id) {
   CHECK(enabled_);
   current_tree_->ShowContextMenu(id);
 }
 
+void AutomationManagerAura::OnChildWindowRemoved(
+    views::AXAuraObjWrapper* parent) {
+  if (!enabled_)
+    return;
+
+  BrowserContext* context = nullptr;
+  if (g_browser_process->profile_manager()) {
+    context = g_browser_process->profile_manager()->GetLastUsedProfile();

[dmazzoni, 2016/08/31 16:33:50]

This is done in two places. I think it'd be better if you just passed nullptr
instead of |context| to SendEvent, and did the same from
AutomationManagerAura::Enable, then have SendEvent be the one to call
GetLastUsedProfile if |context| is nullptr.

[David Tseng, 2016/08/31 21:06:42]

Done.

+  }
+
+  if (!context) {
+    LOG(WARNING) << "Accessibility notification but no browser context";
+    return;
+  }
+
+  if (!parent)
+    parent = current_tree_->GetRoot();
+
+  SendEvent(context, parent, ui::AX_EVENT_CHILDREN_CHANGED);
+}
+
 AutomationManagerAura::AutomationManagerAura()
     : enabled_(false), processing_events_(false) {}
 
 AutomationManagerAura::~AutomationManagerAura() {
 }
 
 void AutomationManagerAura::ResetSerializer() {
   current_tree_serializer_.reset(
       new AuraAXTreeSerializer(current_tree_.get()));
 }
@@ skipping 27 matching lines @@
 
   processing_events_ = false;
   auto pending_events_copy = pending_events_;
   pending_events_.clear();
   for (size_t i = 0; i < pending_events_copy.size(); ++i) {
     SendEvent(context,
               pending_events_copy[i].first,
               pending_events_copy[i].second);
   }
 }