Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2295173002: [wasm] Use the right control input for the diamond in GrowMemory. (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use the right control input for the diamond in GrowMemory. The fuzzer found out that "start" is not always a good control input for a diamond. R=titzer@chromium.org Committed: https://crrev.com/dd9995c066bbbd4631e59491af6fefd3514da445 Cr-Commit-Position: refs/heads/master@{#39046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 3 months ago (2016-08-31 11:15:39 UTC) #1
titzer
On 2016/08/31 11:15:39, ahaas wrote: lgtm. Nice find.
4 years, 3 months ago (2016-08-31 11:22:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295173002/1
4 years, 3 months ago (2016-08-31 12:29:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 12:32:18 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 12:32:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd9995c066bbbd4631e59491af6fefd3514da445
Cr-Commit-Position: refs/heads/master@{#39046}

Powered by Google App Engine
This is Rietveld 408576698