third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp - Issue 2295153004: Fix a null-deref in Upgrade-Insecure-Request's handling of unique origins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp

Issue 2295153004: Fix a null-deref in Upgrade-Insecure-Request's handling of unique origins. (Closed)

Patch Set: Test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp

diff --git a/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp b/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp

index fdc9c60ab84d04306c2c4c5ab8da2dc3c1d23015..2f1f9c255a8fd8064a26df5d2f3bcefcaa1e2ebf 100644

--- a/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp

+++ b/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp

@@ -65,10 +65,11 @@ TEST_F(ContentSecurityPolicyTest, ParseInsecureRequestPolicy)

document = Document::create();

document->setSecurityOrigin(secureOrigin);

+ document->setURL(secureURL);

csp->bindToExecutionContext(document.get());

EXPECT_EQ(test.expectedPolicy, document->getInsecureRequestPolicy());

bool expectUpgrade = test.expectedPolicy & kUpgradeInsecureRequests;

- EXPECT_EQ(expectUpgrade, document->insecureNavigationsToUpgrade()->contains(secureOrigin->host().impl()->hash()));

+ EXPECT_EQ(expectUpgrade, document->insecureNavigationsToUpgrade()->contains(document->url().host().impl()->hash()));

}

// Report-Only

« no previous file with comments | « third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp ('k') | no next file » | no next file with comments »