Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2295103002: Fixing the pushing gdbserver problem while setting --su-prefix="su -c" (Closed)

Created:
4 years, 3 months ago by cathiechentx
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing the pushing gdbserver problem while setting --su-prefix="su -c" COMMAND_PREFIX and COMMAND_SUFFIX should be used simultaneously BUG= Committed: https://crrev.com/899f5b3f086923998716888ebd1d38168f4a25aa Cr-Commit-Position: refs/heads/master@{#415623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/android/adb_gdb View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
cathiechentx
hi jbudorick, adb_gdb_content_shell won't work when su-prefix set. The COMMAND_SUFFIX has been missed while pushing ...
4 years, 3 months ago (2016-08-31 08:17:29 UTC) #4
jbudorick
lgtm
4 years, 3 months ago (2016-08-31 13:01:41 UTC) #5
jbudorick
On 2016/08/31 08:17:29, cathiechentx wrote: > hi jbudorick, > adb_gdb_content_shell won't work when su-prefix set. ...
4 years, 3 months ago (2016-08-31 13:02:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295103002/1
4 years, 3 months ago (2016-08-31 13:04:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 13:50:17 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 13:52:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/899f5b3f086923998716888ebd1d38168f4a25aa
Cr-Commit-Position: refs/heads/master@{#415623}

Powered by Google App Engine
This is Rietveld 408576698