[ios] Implemented LoadHtml w/o using data:// URLs.

[ios] Implemented LoadHtml w/o using data:// URLs.

This allows loading HTML and setting a specific URL (last part is needed
by suggestions tests, which currently use private API to set the URL).

BUG=619687
Committed: https://crrev.com/7d93683d73e6bb131651275c752a0792f2733410
Cr-Commit-Position: refs/heads/master@{#416151}

[Eugene But (OOO till 7-30), 2016-09-01 00:37:20]

eugenebut@chromium.org changed reviewers:
+ jyquinn@chromium.org

[Jackie Quinn, 2016-09-01 22:27:03]

Woohoo! 

A question about load cycle...

https://codereview.chromium.org/2295053003/diff/40001/ios/web/public/test/web...
File ios/web/public/test/web_test_with_web_state.mm (right):

https://codereview.chromium.org/2295053003/diff/40001/ios/web/public/test/web...
ios/web/public/test/web_test_with_web_state.mm:83:
ASSERT_EQ(web::LOAD_REQUESTED, web_controller.loadPhase);
Are we sure to catch it in LOAD_REQUESTED here? Any chance we would hit
PAGE_LOADING here?

https://codereview.chromium.org/2295053003/diff/40001/ios/web/public/test/web...
ios/web/public/test/web_test_with_web_state.mm:85: while
(web_controller.loadPhase != PAGE_LOADING)
web::PAGE_LOADING?

https://codereview.chromium.org/2295053003/diff/40001/ios/web/public/test/web...
ios/web/public/test/web_test_with_web_state.mm:97: while
(web_controller.loadPhase != PAGE_LOADED)
web::PAGE_LOADED? or maybe load requested above doesn't need web namespace.

[Eugene But (OOO till 7-30), 2016-09-01 23:02:14]

PTAL

https://codereview.chromium.org/2295053003/diff/40001/ios/web/public/test/web...
File ios/web/public/test/web_test_with_web_state.mm (right):

https://codereview.chromium.org/2295053003/diff/40001/ios/web/public/test/web...
ios/web/public/test/web_test_with_web_state.mm:83:
ASSERT_EQ(web::LOAD_REQUESTED, web_controller.loadPhase);
On 2016/09/01 22:27:03, Jackie Quinn wrote:
> Are we sure to catch it in LOAD_REQUESTED here? Any chance we would hit
> PAGE_LOADING here?
This worked with all tests we have, so I don't think PAGE_LOADING could happen
here. So far I was running this only locally but I want to give it a try on the
bots :)

https://codereview.chromium.org/2295053003/diff/40001/ios/web/public/test/web...
ios/web/public/test/web_test_with_web_state.mm:85: while
(web_controller.loadPhase != PAGE_LOADING)
On 2016/09/01 22:27:03, Jackie Quinn wrote:
> web::PAGE_LOADING?
This code is already in web namespace, so I removed web:: from other places
instead.

https://codereview.chromium.org/2295053003/diff/40001/ios/web/public/test/web...
ios/web/public/test/web_test_with_web_state.mm:97: while
(web_controller.loadPhase != PAGE_LOADED)
On 2016/09/01 22:27:03, Jackie Quinn wrote:
> web::PAGE_LOADED? or maybe load requested above doesn't need web namespace.
Yeah, I removed namespace.

[Jackie Quinn, 2016-09-01 23:04:29]

On 2016/09/01 23:02:14, Eugene But wrote:
> PTAL
> 
>
https://codereview.chromium.org/2295053003/diff/40001/ios/web/public/test/web...
> File ios/web/public/test/web_test_with_web_state.mm (right):
> 
>
https://codereview.chromium.org/2295053003/diff/40001/ios/web/public/test/web...
> ios/web/public/test/web_test_with_web_state.mm:83:
> ASSERT_EQ(web::LOAD_REQUESTED, web_controller.loadPhase);
> On 2016/09/01 22:27:03, Jackie Quinn wrote:
> > Are we sure to catch it in LOAD_REQUESTED here? Any chance we would hit
> > PAGE_LOADING here?
> This worked with all tests we have, so I don't think PAGE_LOADING could happen
> here. So far I was running this only locally but I want to give it a try on
the
> bots :)
> 
>
https://codereview.chromium.org/2295053003/diff/40001/ios/web/public/test/web...
> ios/web/public/test/web_test_with_web_state.mm:85: while
> (web_controller.loadPhase != PAGE_LOADING)
> On 2016/09/01 22:27:03, Jackie Quinn wrote:
> > web::PAGE_LOADING?
> This code is already in web namespace, so I removed web:: from other places
> instead.
> 
>
https://codereview.chromium.org/2295053003/diff/40001/ios/web/public/test/web...
> ios/web/public/test/web_test_with_web_state.mm:97: while
> (web_controller.loadPhase != PAGE_LOADED)
> On 2016/09/01 22:27:03, Jackie Quinn wrote:
> > web::PAGE_LOADED? or maybe load requested above doesn't need web namespace.
> Yeah, I removed namespace.

Cool. lgtm

[Eugene But (OOO till 7-30), 2016-09-02 00:21:36]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-09-02 00:21:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-09-02 00:23:16]

Thanks!

[commit-bot: I haz the power, 2016-09-02 01:10:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-02 01:12:43]

Description was changed from

==========
[ios] Implemented LoadHtml w/o using data:// URLs.

This allows loading HTML and setting a specific URL (last part is needed
by suggestions tests, which currently use private API to set the URL).

BUG=619687
==========

to

==========
[ios] Implemented LoadHtml w/o using data:// URLs.

This allows loading HTML and setting a specific URL (last part is needed
by suggestions tests, which currently use private API to set the URL).

BUG=619687

Committed: https://crrev.com/7d93683d73e6bb131651275c752a0792f2733410
Cr-Commit-Position: refs/heads/master@{#416151}
==========

[commit-bot: I haz the power, 2016-09-02 01:12:44]

Patchset 4 (id:??) landed as
https://crrev.com/7d93683d73e6bb131651275c752a0792f2733410
Cr-Commit-Position: refs/heads/master@{#416151}

[noyau (Ping after 24h), 2016-09-02 12:40:19]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2306053002/ by noyau@chromium.org.

The reason for reverting is: Breaking iOS build..