Skip omnibox default match update check when input is from omnibox focus

Skip omnibox default match update check when input is from omnibox focus

Previously we would avoid this check for the ZeroSuggestProvider
specifically, but it should be avoided in all cases where the omnibox input
was not created by the user.

This change also fixes a bug on iOS where selecting an autocomplete
suggestion after deleting the auto-filled input text would cause this check
to fail.

BUG=642506
Committed: https://crrev.com/cd3f511431f2ac322a69d024b20ae012c9f21a92
Cr-Commit-Position: refs/heads/master@{#415993}

[mattreynolds, 2016-09-01 01:27:08]

mattreynolds@chromium.org changed reviewers:
+ mpearson@chromium.org

[mattreynolds, 2016-09-01 01:27:09]

Hi Mark, PTAL

[Mark P, 2016-09-01 04:16:22]

lgtm with one suggestion below

https://codereview.chromium.org/2295043005/diff/1/components/omnibox/browser/...
File components/omnibox/browser/omnibox_edit_model.cc (right):

https://codereview.chromium.org/2295043005/diff/1/components/omnibox/browser/...
components/omnibox/browser/omnibox_edit_model.cc:668: // (because the user does
not modify the omnibox for ZeroSuggest), so for
Instead of first clause and parenthetical remark, perhaps:
// These elapsed times don't really make sense for matches that come from
omnibox focus (because the user did not modify the omnibox), so for ...

[mattreynolds, 2016-09-01 17:15:02]

Thanks Mark

https://codereview.chromium.org/2295043005/diff/1/components/omnibox/browser/...
File components/omnibox/browser/omnibox_edit_model.cc (right):

https://codereview.chromium.org/2295043005/diff/1/components/omnibox/browser/...
components/omnibox/browser/omnibox_edit_model.cc:668: // (because the user does
not modify the omnibox for ZeroSuggest), so for
On 2016/09/01 04:16:22, Mark P wrote:
> Instead of first clause and parenthetical remark, perhaps:
> // These elapsed times don't really make sense for matches that come from
> omnibox focus (because the user did not modify the omnibox), so for ...

Done.

[mattreynolds, 2016-09-01 17:15:06]

The CQ bit was checked by mattreynolds@chromium.org

[mattreynolds, 2016-09-01 17:15:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org
Link to the patchset: https://codereview.chromium.org/2295043005/#ps20001
(title: "revise comment")

[commit-bot: I haz the power, 2016-09-01 17:15:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 17:58:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-01 17:59:31]

Description was changed from

==========
Skip omnibox default match update check when input is from omnibox focus

Previously we would avoid this check for the ZeroSuggestProvider
specifically, but it should be avoided in all cases where the omnibox input
was not created by the user.

This change also fixes a bug on iOS where selecting an autocomplete
suggestion after deleting the auto-filled input text would cause this check
to fail.

BUG=642506
==========

to

==========
Skip omnibox default match update check when input is from omnibox focus

Previously we would avoid this check for the ZeroSuggestProvider
specifically, but it should be avoided in all cases where the omnibox input
was not created by the user.

This change also fixes a bug on iOS where selecting an autocomplete
suggestion after deleting the auto-filled input text would cause this check
to fail.

BUG=642506

Committed: https://crrev.com/cd3f511431f2ac322a69d024b20ae012c9f21a92
Cr-Commit-Position: refs/heads/master@{#415993}
==========

[commit-bot: I haz the power, 2016-09-01 17:59:32]

Patchset 2 (id:??) landed as
https://crrev.com/cd3f511431f2ac322a69d024b20ae012c9f21a92
Cr-Commit-Position: refs/heads/master@{#415993}