Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2295043003: Revert of It's time to bring subprocess42 to depot_tools. (Closed)

Created:
4 years, 3 months ago by tandrii(chromium)
Modified:
4 years, 3 months ago
Reviewers:
M-A Ruel, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of It's time to bring subprocess42 to depot_tools. (patchset #1 id:1 of https://codereview.chromium.org/2291223003/ ) Reason for revert: Speculative revert because it might be breaking presubmit in depot_tools. Original issue's description: > It's time to bring subprocess42 to depot_tools. > > The immediate need is to properly kill git fetch and its sub-spawned > process from gclient. > > R=maruel@chromium.org, hinoka@chromium.org > BUG=635641 > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/6d3c290164360907fe08784093e36314069e689f TBR=hinoka@chromium.org,maruel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635641 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/7b787b8642623e39eafce83595c187660528af9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -607 lines) Patch
D subprocess42.py View 1 chunk +0 lines, -607 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tandrii(chromium)
Created Revert of It's time to bring subprocess42 to depot_tools.
4 years, 3 months ago (2016-08-31 17:58:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295043003/1
4 years, 3 months ago (2016-08-31 17:58:26 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 17:58:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/7b787b8642623e...

Powered by Google App Engine
This is Rietveld 408576698